From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#29456: [PATCH] Add command for cycling between CSS color formats Date: Mon, 27 Nov 2017 19:07:56 +0200 Message-ID: <83indv645v.fsf@gnu.org> References: <1511709711.2341.0@smtp.gmail.com> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1511802558 610 195.159.176.226 (27 Nov 2017 17:09:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 27 Nov 2017 17:09:18 +0000 (UTC) Cc: 29456@debbugs.gnu.org, tom@tromey.com, monnier@iro.umontreal.ca To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 27 18:09:10 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJMu1-0007rJ-Vy for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Nov 2017 18:09:06 +0100 Original-Received: from localhost ([::1]:33841 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJMu9-0006y2-DT for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Nov 2017 12:09:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJMu3-0006xm-PW for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 12:09:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJMty-0000dN-8N for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 12:09:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52487) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJMty-0000d2-4q for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 12:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJMtx-0007Fi-Ss for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 12:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Nov 2017 17:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29456 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29456-submit@debbugs.gnu.org id=B29456.151180252027848 (code B ref 29456); Mon, 27 Nov 2017 17:09:01 +0000 Original-Received: (at 29456) by debbugs.gnu.org; 27 Nov 2017 17:08:40 +0000 Original-Received: from localhost ([127.0.0.1]:32935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJMtc-0007F6-1W for submit@debbugs.gnu.org; Mon, 27 Nov 2017 12:08:40 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJMta-0007Es-M3 for 29456@debbugs.gnu.org; Mon, 27 Nov 2017 12:08:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJMtR-0000LA-CZ for 29456@debbugs.gnu.org; Mon, 27 Nov 2017 12:08:33 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJMt6-00006O-TF; Mon, 27 Nov 2017 12:08:08 -0500 Original-Received: from [176.228.60.248] (port=2128 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eJMt6-0000Ht-56; Mon, 27 Nov 2017 12:08:08 -0500 In-reply-to: <1511709711.2341.0@smtp.gmail.com> (message from Simen =?UTF-8?Q?Heggest=C3=B8yl?= on Sun, 26 Nov 2017 16:21:51 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140463 Archived-At: > Date: Sun, 26 Nov 2017 16:21:51 +0100 > From: Simen Heggestøyl > Cc: Tom Tromey , Stefan Monnier > > The attached patch adds a new command 'css-cycle-color-format' to CSS > mode, for cycling between color formats (e.g. "black" => "#000000" => > "rgb(0, 0, 0)" => "black"), bound to 'C-c C-f'. Thanks. These functions are confusingly similar to, but subtly different from, the similar functions in color.el, and in general the whole system of color conversions used by Emacs for its display needs. Here's a tell-tale example: (css--web-color-to-4-dpc "#fff") => "#ffffffffffff" but (apply 'color-rgb-to-hex (color-name-to-rgb "#fff")) => "#f0f0f0f0f0f0" The latter follows the X color definitions, so why does css-mode.el need a different interpretation of the hex-RGB notation? My fear is that someone will mix css-mode functions with those from elsewhere in Emacs, and will bump into confusing and contradicting results. Is it possible to avoid that?