unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 30364@debbugs.gnu.org, alan@idiocy.org, npostavs@gmail.com,
	npostavs@users.sourceforge.net
Subject: bug#30364: 26.0.91; thread crash on macos
Date: Sun, 18 Feb 2018 22:15:57 +0200	[thread overview]
Message-ID: <83inau9hqa.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48x4s5cBw7aiD=R80x7HZMwSKFP7uneR=uE79vHm0e0VhQ@mail.gmail.com> (message from Aaron Jensen on Sun, 18 Feb 2018 11:49:45 -0800)

> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Sun, 18 Feb 2018 11:49:45 -0800
> Cc: Noam Postavsky <npostavs@gmail.com>, 30364@debbugs.gnu.org, 
> 	Noam Postavsky <npostavs@users.sourceforge.net>, Alan Third <alan@idiocy.org>
> 
> I was actually imagining that when a thread needed a GC it would
> request that the GC be done on the main thread (blocking while it
> waits). I have no idea how difficult that would be to implement.

Neither do I.

> > If threads get only 512KB of stack, it's a small wonder that they
> > crash in GC.  IME, you need at least 3MB to endure a full GC in Emacs.
> 
> I upped the required stack size to 5MB and it fixed the crash for me.
> I don't know what the right size should bed, I could go w/ the 3MB you
> call out here, but I went a little higher to be safe. See attached
> patch. I'm assuming that pthread_attr_setstacksize is available
> everywhere pthread is. I don't know if that's an ok assumption or not.

I think for 32-bit Emacs 3MB will do, but 64-bit build might need
more, like 4 or 5.  The MS-Windows build gives each thread the same
amount of stack as for the main program, which means 8MB.

I hope someone who is familiar with pthreads will chime in regarding
the portability issues.

Thanks.





  reply	other threads:[~2018-02-18 20:15 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06  8:21 bug#30364: 26.0.91; thread crash on macos Aaron Jensen
2018-02-14  1:05 ` Noam Postavsky
2018-02-14  1:22   ` Aaron Jensen
2018-02-17 14:44     ` Noam Postavsky
2018-02-17 17:58       ` Aaron Jensen
2018-02-17 18:17         ` Eli Zaretskii
2018-02-17 18:40           ` Aaron Jensen
2018-02-17 18:55             ` Eli Zaretskii
2018-02-18  1:58               ` Aaron Jensen
2018-02-18  4:51                 ` Eli Zaretskii
2018-02-18  4:54                   ` Aaron Jensen
2018-02-18 16:45                     ` Eli Zaretskii
     [not found]                       ` <CAHyO48y+c21biWxQDTMvW2PkSKW6TzZVWQ94yUPN_4n3utDv5A@mail.gmail.com>
2018-02-18 18:25                         ` Eli Zaretskii
2018-02-18 18:38                           ` Aaron Jensen
2018-02-18 18:39                             ` Aaron Jensen
2018-02-18 18:59                               ` Aaron Jensen
2018-02-18 19:32                                 ` Eli Zaretskii
2018-02-18 19:49                                   ` Aaron Jensen
2018-02-18 20:15                                     ` Eli Zaretskii [this message]
2018-02-18 21:12                                       ` Aaron Jensen
2018-02-19  3:29                                         ` Eli Zaretskii
2018-02-19 17:24                                           ` Paul Eggert
2018-02-19 17:29                                             ` Daniel Colascione
2018-02-19 18:39                                               ` Eli Zaretskii
2018-02-19 18:33                                             ` Eli Zaretskii
2018-02-19 18:47                                               ` Aaron Jensen
2018-02-19 20:08                                                 ` Paul Eggert
2018-02-19 20:16                                                   ` Aaron Jensen
2018-02-25 20:52                                                     ` Aaron Jensen
2018-02-27 17:30                                                       ` Paul Eggert
2018-02-27 17:38                                                         ` Aaron Jensen
2018-02-27 17:44                                                           ` Paul Eggert
2018-02-28  5:33                                                         ` Aaron Jensen
2018-02-28 15:33                                                           ` Eli Zaretskii
2018-02-28 15:35                                                             ` Aaron Jensen
2018-02-28 16:20                                                               ` Eli Zaretskii
2018-02-28 17:32                                                                 ` Aaron Jensen
2018-02-28 17:38                                                                   ` Eli Zaretskii
2018-02-28 17:59                                                                     ` Aaron Jensen
2018-02-28 18:07                                                                       ` Aaron Jensen
2018-02-28 19:15                                                                         ` Paul Eggert
2018-02-28 20:36                                                                           ` Eli Zaretskii
2018-03-01  0:31                                                                             ` Paul Eggert
2018-03-01  8:37                                                                               ` Aaron Jensen
2018-05-13 15:13                                                                               ` Noam Postavsky
2018-05-13 16:26                                                                                 ` Eli Zaretskii
2018-05-14 20:03                                                                                   ` Paul Eggert
2018-02-28 16:19                                                           ` Paul Eggert
2018-02-18 19:07                               ` Eli Zaretskii
2018-02-18 19:04                             ` Eli Zaretskii
2018-02-18 11:01                 ` Alan Third
2018-02-17 18:23         ` Alan Third

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83inau9hqa.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30364@debbugs.gnu.org \
    --cc=aaronjensen@gmail.com \
    --cc=alan@idiocy.org \
    --cc=npostavs@gmail.com \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).