From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: , 36143@debbugs.gnu.org, stefan@marxist.se
Subject: bug#36143: [PATCH] Fix typo in src/keyboard.c)
Date: Sun, 09 Jun 2019 16:56:41 +0300 [thread overview]
Message-ID: <83imtec15y.fsf@gnu.org> (raw)
In-Reply-To: <87lfya28uj.fsf_-_@gmail.com> (message from Noam Postavsky on Sun, 09 Jun 2019 09:20:52 -0400)
> From: Noam Postavsky <npostavs@gmail.com>
> Date: Sun, 09 Jun 2019 09:20:52 -0400
> Cc: , Stefan Kangas <stefan@marxist.se>
>
> Oh, I also didn't realize C sources were supposed to be TABified. Maybe
> .dir-locals.el should have an explicit (indent-tabs-mode . t) setting
> under c-mode?
It'd be fine with me, but maybe others will object.
I think it's okay to indent new C code with spaces, but when a few
lines are modified in an otherwise TAB-indented block, that makes the
source unaligned when reindented, so IMO should be avoided. And in
this case, it was even more extreme: a line was modified only very
slightly, so changing whitespace for only that single line was IMO
gross.
next prev parent reply other threads:[~2019-06-09 13:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-09 3:16 bug#36143: [PATCH] Fix typo in src/keyboard.c Stefan Kangas
2019-06-09 6:26 ` Eli Zaretskii
2019-06-09 8:00 ` Stefan Kangas
[not found] ` <handler.36143.D36143.156006163211770.notifdone@debbugs.gnu.org>
2019-06-09 13:20 ` bug#36143: [PATCH] Fix typo in src/keyboard.c) Noam Postavsky
2019-06-09 13:56 ` Eli Zaretskii [this message]
2019-06-09 14:07 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imtec15y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36143@debbugs.gnu.org \
--cc=npostavs@gmail.com \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).