From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 17 Oct 2019 09:40:25 +0300 Message-ID: <83imondgdi.fsf@gnu.org> References: <83bluhf7nz.fsf@gnu.org> <20191016111004.oialbyleokafpccz@Ergus> <87k194fvn7.fsf@mail.linkov.net> <83y2xkcyu9.fsf@gnu.org> <87o8yg5v80.fsf@mail.linkov.net> <83o8ygcvb0.fsf@gnu.org> <87mue01lu5.fsf@mail.linkov.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="5068"; mail-complaints-to="usenet@blaine.gmane.org" Cc: andreyorst@gmail.com, spacibba@aol.com, 37774@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Oct 17 08:41:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iKzTJ-00019O-AC for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 08:41:17 +0200 Original-Received: from localhost ([::1]:37388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKzTH-0005J0-KP for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Oct 2019 02:41:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56846) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iKzT5-0005IL-HG for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 02:41:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iKzT4-00015d-El for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 02:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38189) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iKzT4-00015Z-C2 for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 02:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iKzT4-0000R2-5D for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2019 02:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2019 06:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15712944491644 (code B ref 37774); Thu, 17 Oct 2019 06:41:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 17 Oct 2019 06:40:49 +0000 Original-Received: from localhost ([127.0.0.1]:47010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKzSr-0000QS-DS for submit@debbugs.gnu.org; Thu, 17 Oct 2019 02:40:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iKzSq-0000QG-6y for 37774@debbugs.gnu.org; Thu, 17 Oct 2019 02:40:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:59666) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iKzSk-0000yo-NJ; Thu, 17 Oct 2019 02:40:42 -0400 Original-Received: from [176.228.60.248] (port=3898 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iKzSk-00050S-70; Thu, 17 Oct 2019 02:40:42 -0400 In-reply-to: <87mue01lu5.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 16 Oct 2019 23:23:14 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169529 Archived-At: > From: Juri Linkov > Cc: spacibba@aol.com, andreyorst@gmail.com, 37774@debbugs.gnu.org > Date: Wed, 16 Oct 2019 23:23:14 +0300 > > >> (custom-set-faces > >> '(region ((((class color) (background light)) (:background "gray90")))) > > > > So maybe we should modify custom-set-faces to preserve the :extend > > attribute? Would that solve the problem? > > I don't know how feasible this is. This looks like a hack. Why do you think it's a hack? > > I don't think I agree. I'm not convinced by the reasons, and I find > > the new appearance not worse (and sometimes better) than the old. > > I find the new appearance better too in most cases, but not > for background colors. I'm talking specifically about background colors: I find the appearance not worse and sometimes better. > >> Because there is no distinctive rectangular header anymore, > >> and no diff hunk blocks. > > > > Sorry, I don't think I follow: how do you mean there's no distinctive > > header and no diff hunk blocks? I see them quite clearly. > > I meant a rectangular header like in other applications. But if the faces are customized to have a distinct foreground color, instead of background, you will see exactly what you see now with the background color. The terminal display of "git diff" and other similar commands does precisely that, and we don't seem to mind the fact that the colors don't align at the end of each line. > Extending to fill-column could be optional. Extending to window edge > could be default for faces with distinct background colors. Extending to > EOL could be default for all other faces. How is this supposed to work, given that any face can be customized to use either of these attributes, or any combination thereof? Once again: other applications do what we do now, and users don't seem to mind.