From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37755: Logic in init_fringe_bitmap should be moved to backends (maybe rif->define_fringe_bitmap) Date: Sat, 26 Oct 2019 13:39:27 +0300 Message-ID: <83imobvli8.fsf@gnu.org> References: <83a7a2gxp0.fsf@gnu.org> <83a79v620e.fsf@gnu.org> <83y2xf4d00.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="256998"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37755@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 26 12:41:03 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iOJVG-0014aY-JU for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Oct 2019 12:41:02 +0200 Original-Received: from localhost ([::1]:39648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOJV9-0000gv-Go for geb-bug-gnu-emacs@m.gmane.org; Sat, 26 Oct 2019 06:40:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60319) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iOJUJ-0007xR-7t for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 06:40:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iOJUI-0001JW-5j for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 06:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59138) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iOJUI-0001JN-32 for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 06:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iOJUH-0007qU-VM for bug-gnu-emacs@gnu.org; Sat, 26 Oct 2019 06:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Oct 2019 10:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 37755-submit@debbugs.gnu.org id=B37755.157208638630128 (code B ref 37755); Sat, 26 Oct 2019 10:40:01 +0000 Original-Received: (at 37755) by debbugs.gnu.org; 26 Oct 2019 10:39:46 +0000 Original-Received: from localhost ([127.0.0.1]:39726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOJU1-0007ps-N2 for submit@debbugs.gnu.org; Sat, 26 Oct 2019 06:39:45 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iOJU0-0007pe-Kv for 37755@debbugs.gnu.org; Sat, 26 Oct 2019 06:39:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39560) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iOJTv-00014s-G0; Sat, 26 Oct 2019 06:39:39 -0400 Original-Received: from [176.228.60.248] (port=1131 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iOJTu-0001jt-RX; Sat, 26 Oct 2019 06:39:39 -0400 In-reply-to: (message from Carlos Pita on Sun, 20 Oct 2019 13:32:36 -0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170189 Archived-At: > From: Carlos Pita > Date: Sun, 20 Oct 2019 13:32:36 -0300 > Cc: 37755@debbugs.gnu.org > > > If RIF is the problem, we could make each terminal backend do this > > initialization unconditionally at dump time. > > According to my rationale above, I don't see any problem at all. But, > as I have said, I ignore everything about the dumper. Yet, I find it > hard to believe that whatever this dumper thing is, it needs the bits > to be in little-endian, 8-bit per row format, or any other > rif-specific pattern. Sorry, we cannot just ignore the dumping issue. We don't want to waste CPU cycles each startup to regenerate these standard bitmaps. So the fringe bit patterns need to be initialized at dump time and dumped together with all the other stuff we prepare at that time. If I understand correctly, the difficulty you had with doing this at dump time was that frame's RIF was not yet set (because dumping works in batch mode, where redisplay interface is not set to the correct GUI frame type). If so, my suggestion is to call the window-system specific initialization function directly. For example, in the X build, you can add code to syms_of_xterm code to call x_define_fringe_bitmap, and similarly for Cairo, w32, etc. Does this proposal resolve the difficulty? If not, please point out what else is missing. Thanks.