From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 38287@debbugs.gnu.org, netjune@outlook.com
Subject: bug#38287: 26.3.50; filenotify.el: the Chinese file name in the event is messy code
Date: Wed, 20 Nov 2019 20:25:02 +0200 [thread overview]
Message-ID: <83imnez9q9.fsf@gnu.org> (raw)
In-Reply-To: <875zje780h.fsf@gmx.de> (message from Michael Albinus on Wed, 20 Nov 2019 18:49:34 +0100)
> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: netjune@outlook.com, 38287@debbugs.gnu.org
> Date: Wed, 20 Nov 2019 18:49:34 +0100
>
> > The strings shown in the image are UTF-8 encoded.
>
> Hmm. kqueue.c is very lazy in using ENCODE_FILE, it uses it only in
> kqueue-add-watch. Maybe it is missing somewhere else?
I see one potential problem: in kqueue-add-watch, you encode the file
name, but then pass it to APIs that generally expect multibyte
(i.e. un-encoded) strings, although they will also work with encoded
unibyte strings. Moreover, you put the unibyte encoded file name into
the watch object. Not sure if this is related to the issue at hand,
but it would be cleaner to make this change:
diff --git a/src/kqueue.c b/src/kqueue.c
index 76d7fc1..1383d7d 100644
--- a/src/kqueue.c
+++ b/src/kqueue.c
@@ -414,7 +414,7 @@ DEFUN ("kqueue-add-watch", Fkqueue_add_watch, Skqueue_add_watch, 3, 3, 0,
}
/* Open file. */
- file = ENCODE_FILE (file);
+ Lisp_Object encoded_file = ENCODE_FILE (file);
oflags = O_NONBLOCK;
#if O_EVTONLY
oflags |= O_EVTONLY;
@@ -426,7 +426,7 @@ DEFUN ("kqueue-add-watch", Fkqueue_add_watch, Skqueue_add_watch, 3, 3, 0,
#else
oflags |= O_NOFOLLOW;
#endif
- fd = emacs_open (SSDATA (file), oflags, 0);
+ fd = emacs_open (SSDATA (encoded_file), oflags, 0);
if (fd == -1)
report_file_error ("File cannot be opened", file);
Btw, I don't think I understand the nature of the problem yet: where
were the unibyte strings shown in the report printed? Did some Emacs
code print them, and if so, where is that code?
next prev parent reply other threads:[~2019-11-20 18:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <aeef7181-2c14-4b93-90fd-dd71993ed3c8@Spark>
2019-11-20 3:50 ` bug#38287: 26.3.50; filenotify.el: the Chinese file name in the event is messy code HaiJun Zhang
2019-11-20 16:32 ` Michael Albinus
2019-11-20 17:35 ` Eli Zaretskii
2019-11-20 17:49 ` Michael Albinus
2019-11-20 18:25 ` Eli Zaretskii [this message]
2019-11-20 18:45 ` Michael Albinus
2019-11-21 0:35 ` HaiJun Zhang
2019-11-21 2:33 ` HaiJun Zhang
2019-11-21 14:42 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imnez9q9.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=38287@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=netjune@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).