From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Sun, 08 Dec 2019 05:32:32 +0200 Message-ID: <83immreblb.fsf@gnu.org> References: <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <83ftiasfdm.fsf@gnu.org> <83lfrulmva.fsf@gnu.org> <76a012f5-8cdd-75d5-322e-a453a612c655@yandex.ru> <83immxjs6q.fsf@gnu.org> <993b2f9c-6052-e791-3d3b-26d5fedd7d12@yandex.ru> <835ziuixke.fsf@gnu.org> <9c4768a5-ecce-68ce-c612-a001b2f6784d@yandex.ru> <8336dxh1ge.fsf@gnu.org> <6c68ceed-156c-a6f2-bf0f-21d7e9eb5692@yandex.ru> <831rthgy3u.fsf@gnu.org> <83o8wkfu63.fsf@gnu.org> <83r21gdnun.fsf@gnu.org> <839f1185-fc0c-0e8b-29fd-5431fb71ab2e@yandex.ru> <83o8wkdk3n.fsf@gnu.org> <45fcbf16-c9b4-ca15-7fa2-e7ea2137218c@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="226038"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 08 04:36:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1idnMl-000wfC-Md for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 Dec 2019 04:36:15 +0100 Original-Received: from localhost ([::1]:55316 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idnMa-0007oe-2i for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 Dec 2019 22:36:13 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47909) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1idnKz-0007j7-Vv for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 22:34:28 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1idnKp-0000zj-TY for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 22:34:18 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44260) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1idnKc-0000kZ-BT for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 22:34:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1idnKc-00050z-9M for bug-gnu-emacs@gnu.org; Sat, 07 Dec 2019 22:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Dec 2019 03:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.157577599419217 (code B ref 37774); Sun, 08 Dec 2019 03:34:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 8 Dec 2019 03:33:14 +0000 Original-Received: from localhost ([127.0.0.1]:50231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idnJq-0004zs-5B for submit@debbugs.gnu.org; Sat, 07 Dec 2019 22:33:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38488) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1idnJo-0004zd-Cx for 37774@debbugs.gnu.org; Sat, 07 Dec 2019 22:33:12 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1idnJU-00007b-D9; Sat, 07 Dec 2019 22:32:54 -0500 Original-Received: from [176.228.60.248] (port=1909 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1idnJS-0007zT-SA; Sat, 07 Dec 2019 22:32:52 -0500 In-reply-to: <45fcbf16-c9b4-ca15-7fa2-e7ea2137218c@yandex.ru> (message from Dmitry Gutov on Sun, 8 Dec 2019 02:42:42 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:173017 Archived-At: > Cc: 37774@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Sun, 8 Dec 2019 02:42:42 +0200 > > On 07.12.2019 21:14, Eli Zaretskii wrote: > > > Our goal is to allow themes "inherit" the :extend attribute without > > having to specify it in their face specs, unlike with other > > attributes. That's the only goal; > > But that's exactly what it does. It does, but the implementation is too general, and might affect other use cases. > > we don't want :extend to behave > > differently from other face attributes in any other context. > > What other contexts do you have in mind? Any context other than a theme defining a face. > What *shouldn't* it do? What we do with any other face attribute. > > If you are saying that we cannot make this change apply only to face > > definitions by themes, > > What other face definitions are there? There's defface, of course, which > we treat differently. And there are theme definitions (both third-party > and "user theme"). All the other situations where face-spec-recalc is called. You listed at least some of them up-thread. > > then it means we don't really understand what > > we could break here, and then I don't think I want this change in > > Emacs 27. Sorry, it's too risky. > > What about the existing risk of breaking every theme out there by doing > nothing? If we don't have a safe solution, we will have to live with that risk, unfortunately. > > But I don't > > consider myself an expert on these matters, so if you say we cannot > > differentiate between general face definition and what themes do, so > > be it.) > > What's a "general face definition"? Everything except theme definition of faces.