From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: rms@gnu.org, 42256@debbugs.gnu.org
Subject: bug#42256: 27.0.50; composition
Date: Tue, 14 Jul 2020 05:36:56 +0300 [thread overview]
Message-ID: <83imeqn7p3.fsf@gnu.org> (raw)
In-Reply-To: <874kqbar8n.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 14 Jul 2020 03:13:12 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: rms@gnu.org, 42256@debbugs.gnu.org
> Date: Tue, 14 Jul 2020 03:13:12 +0300
>
> I tried, but got a different output:
The output you get depends on the font as well, so I see no problem
here.
> > And at position 872 you can see an even more stark example: instead of
> > 2 characters, we show 8(!).
>
> I don't understand where these 8 characters are coming from.
> This composition of 8 characters is returned by find-composition.
> Maybe the bug is in find-composition?
No, there's no bug in find-composition: it returns what we should pass
to the text shaper. The problem here is that your code assumes all
the characters we passed to the shaper are a single grapheme cluster,
which is not true.
I suggest to look at the code which displays the "Composed with" line
and decides which characters to show there, and do the same in your
addition.
Thanks.
next prev parent reply other threads:[~2020-07-14 2:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 2:41 bug#42256: 27.0.50; composition Richard Stallman
2020-07-08 14:18 ` Eli Zaretskii
2020-07-09 3:01 ` Richard Stallman
2020-07-09 17:51 ` Eli Zaretskii
2020-07-09 23:36 ` Juri Linkov
2020-07-10 6:21 ` Eli Zaretskii
2020-07-11 2:17 ` Richard Stallman
2020-07-11 23:57 ` Juri Linkov
2020-07-12 15:40 ` Eli Zaretskii
2020-07-12 23:35 ` Juri Linkov
2020-07-13 3:37 ` Eli Zaretskii
2020-07-13 13:39 ` Eli Zaretskii
2020-07-14 0:13 ` Juri Linkov
2020-07-14 2:36 ` Eli Zaretskii [this message]
2020-07-14 23:20 ` Juri Linkov
2020-07-15 14:39 ` Eli Zaretskii
2020-07-15 23:43 ` Juri Linkov
2020-07-16 16:40 ` Eli Zaretskii
2020-07-13 2:56 ` Richard Stallman
2020-07-10 3:52 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imeqn7p3.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=42256@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).