From: Eli Zaretskii <eliz@gnu.org>
To: "Philip K." <philip@warpmail.net>
Cc: 42386@debbugs.gnu.org
Subject: bug#42386: Acknowledgement ([PATCH] Handle symbols in project-kill-buffers-ignores)
Date: Thu, 16 Jul 2020 18:14:17 +0300 [thread overview]
Message-ID: <83imenlcfq.fsf@gnu.org> (raw)
In-Reply-To: <875zankfrk.fsf@warpmail.net> (philip@warpmail.net)
> From: "Philip K." <philip@warpmail.net>
> Date: Thu, 16 Jul 2020 10:47:43 +0200
>
> Each condition is either a regular expression matching a buffer
> -name, or a predicate function that takes a buffer object as
> -argument and returns non-nil if it matches. Buffers that match
> -any of the conditions will not be killed."
> - :type '(repeat (choice regexp function))
> +name, a predicate function that takes a buffer object as argument
> +and returns non-nil if it matches, or a symbol protecting buffers
> +of certain major modes.
The part you added to the doc string is unclear: how can a symbol
"protect buffers of certain major modes"? (I think I can guess what
you mean, but readers of doc strings should be guessing.)
> - ((functionp c)
> + ((and (symbolp c)
> + (provided-mode-derived-p
> + (buffer-local-value 'major-mode buf)
> + c)))
> + ((and (not (symbolp c))
> + (functionp c))
> (funcall c buf))))
Is this logic correct and reliable? A function is a symbol, and there
could be symbols that have both a function cell and a variable cell --
how does this cope with that?
And why do you require a function not to be a symbol? I'm probably
missing something.
Thanks.
next prev parent reply other threads:[~2020-07-16 15:14 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 8:15 bug#42386: [PATCH] Handle symbols in project-kill-buffers-ignores Philip K.
[not found] ` <handler.42386.B.159488736413990.ack@debbugs.gnu.org>
2020-07-16 8:47 ` bug#42386: Acknowledgement ([PATCH] Handle symbols in project-kill-buffers-ignores) Philip K.
2020-07-16 15:14 ` Eli Zaretskii [this message]
2020-07-16 18:08 ` Philip K.
2020-07-16 18:16 ` Philip K.
2020-07-16 19:35 ` Eli Zaretskii
2020-07-16 22:22 ` Philip K.
2020-07-17 6:38 ` Eli Zaretskii
2020-07-17 8:16 ` Philip K.
2020-07-17 10:49 ` Eli Zaretskii
2020-07-17 11:17 ` Philip K.
2020-07-17 11:26 ` Eli Zaretskii
2020-07-17 15:30 ` Philip K.
2020-07-17 15:43 ` Dmitry Gutov
2020-07-17 17:16 ` Philip K.
2020-07-17 22:21 ` Dmitry Gutov
2020-07-18 12:48 ` Philip K.
2020-07-19 23:10 ` Dmitry Gutov
2020-07-20 12:07 ` Philip K.
2020-07-20 13:39 ` Dmitry Gutov
2020-07-21 9:11 ` Philip K.
2020-07-21 14:27 ` Eli Zaretskii
2020-07-21 18:35 ` Philip K.
2020-07-21 18:57 ` Eli Zaretskii
2020-07-21 20:47 ` Dmitry Gutov
2020-07-21 18:45 ` Dmitry Gutov
2020-07-21 18:51 ` Philip K.
2020-07-27 16:26 ` Dmitry Gutov
2020-07-27 18:33 ` Philip K.
2020-07-28 22:33 ` Dmitry Gutov
2020-07-16 18:41 ` Dmitry Gutov
2020-07-16 22:46 ` Juri Linkov
2020-07-17 0:23 ` Dmitry Gutov
2020-07-16 13:43 ` bug#42386: [PATCH] Handle symbols in project-kill-buffers-ignores Dmitry Gutov
2020-07-16 18:00 ` Philip K.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83imenlcfq.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=42386@debbugs.gnu.org \
--cc=philip@warpmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).