From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#13521: `sort-lines' on the empty region Date: Fri, 21 Aug 2020 10:36:42 +0300 Message-ID: <83imdcbgc5.fsf@gnu.org> References: <20130122085354.75ced82538551655e724e0ea@gmail.com> <83mu2objro.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36088"; mail-complaints-to="usenet@ciao.gmane.io" Cc: xfq.free@gmail.com, rgm@gnu.org, monnier@iro.umontreal.ca, 13521@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 21 09:37:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k91bq-0009FK-U8 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 09:37:10 +0200 Original-Received: from localhost ([::1]:50664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k91bp-0004JP-HF for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Aug 2020 03:37:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k91bi-0004Ij-Kn for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 03:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k91bi-0007P4-Az for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 03:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k91bi-0005Rv-7J for bug-gnu-emacs@gnu.org; Fri, 21 Aug 2020 03:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Aug 2020 07:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13521-submit@debbugs.gnu.org id=B13521.159799541820938 (code B ref 13521); Fri, 21 Aug 2020 07:37:02 +0000 Original-Received: (at 13521) by debbugs.gnu.org; 21 Aug 2020 07:36:58 +0000 Original-Received: from localhost ([127.0.0.1]:44899 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k91be-0005Rd-GW for submit@debbugs.gnu.org; Fri, 21 Aug 2020 03:36:58 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k91bc-0005RH-0L for 13521@debbugs.gnu.org; Fri, 21 Aug 2020 03:36:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:55947) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k91bW-0007OV-8N; Fri, 21 Aug 2020 03:36:50 -0400 Original-Received: from [176.228.60.248] (port=1079 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1k91bU-0008Lo-Gd; Fri, 21 Aug 2020 03:36:48 -0400 In-Reply-To: (message from Stefan Kangas on Fri, 21 Aug 2020 00:15:31 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:185820 Archived-At: > From: Stefan Kangas > Date: Fri, 21 Aug 2020 00:15:31 -0700 > Cc: monnier@iro.umontreal.ca, xfq.free@gmail.com, rgm@gnu.org, > 13521@debbugs.gnu.org > > > How frequently did you see a buffer in Emacs with no region in it? > > IME, it takes about 2 commands since buffer creation to have a region > > in it. So I predict users to be tripped by this feature quite a lot: > > they will think there's no region, invoke the command, and get some > > arbitrary region sorted. Requiring them to always provide the region > > avoids this pitfall, since the user is forced to make sure the region > > is where he or she wants it. And marking the whole buffer is just 2 > > key-presses away. > > > > So I think this change will annoy more than help. > > Sorry, the correct terminology I should have used is "active region". > This is as tested by `use-region-p'. Compare the test I introduce also > to the one in `flush-lines', where I lifted it from. So if the user has transient-mark-mode disabled (which is what I do), the command will always sort the entire buffer? Or did I misunderstand something?