From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44674: 28.0.50; Adding current-cpu-time for performance tests Date: Mon, 16 Nov 2020 21:12:46 +0200 Message-ID: <83ima5ru8h.fsf@gnu.org> References: <1BDDC2C4-2831-460F-AC48-C353664D28D2@gnu.org> <831rgtte5d.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24648"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44674@debbugs.gnu.org, monnier@iro.umontreal.ca To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 16 20:35:45 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kekHx-0006Id-Bs for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 20:35:45 +0100 Original-Received: from localhost ([::1]:34190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kekHw-0002gN-8l for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 16 Nov 2020 14:35:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kejwz-00078y-TU for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 14:14:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45758) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kejww-0003HK-KP for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 14:14:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kejww-00034r-FR for bug-gnu-emacs@gnu.org; Mon, 16 Nov 2020 14:14:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 16 Nov 2020 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44674 X-GNU-PR-Package: emacs Original-Received: via spool by 44674-submit@debbugs.gnu.org id=B44674.160555398711756 (code B ref 44674); Mon, 16 Nov 2020 19:14:02 +0000 Original-Received: (at 44674) by debbugs.gnu.org; 16 Nov 2020 19:13:07 +0000 Original-Received: from localhost ([127.0.0.1]:57304 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kejw3-00033Y-Ae for submit@debbugs.gnu.org; Mon, 16 Nov 2020 14:13:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kejw2-00032v-E0 for 44674@debbugs.gnu.org; Mon, 16 Nov 2020 14:13:06 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39075) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kejvx-0002zW-52; Mon, 16 Nov 2020 14:13:01 -0500 Original-Received: from [176.228.60.248] (port=1534 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kejvo-0005u7-Pu; Mon, 16 Nov 2020 14:12:55 -0500 In-Reply-To: (message from Philipp Stephani on Mon, 16 Nov 2020 19:31:47 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:193464 Archived-At: > From: Philipp Stephani > Date: Mon, 16 Nov 2020 19:31:47 +0100 > Cc: 44674@debbugs.gnu.org, Stefan Monnier > > Am Mo., 16. Nov. 2020 um 18:17 Uhr schrieb Eli Zaretskii : > > > > > From: Philipp Stephani > > > Date: Mon, 16 Nov 2020 12:46:07 +0100 > > > Cc: 44674@debbugs.gnu.org, Stefan Monnier > > > > > > > Btw, once this goes in, how about making benchmark-run use it? > > > > > > benchmark-run measures walltime, not CPU time > > > > It does now, but we may want to change that. > > That would be a breaking change. I could argue that it's a bugfix. > > Does it really make > > sense to "benchmark" something using elapsed time? > > Yes, the benchmarks I know all measure wall time. After all, that's > what the user cares about. ??? On a system that is heavily loaded, and Emacs doesn't get an execution unit close to 100% of the time, the wallclock time can be so skewed as to defeat any meaningful measurements. E.g., imagine that you are running a benchmark while (another version of) Emacs is being built with "make -jN", with N large enough to make all the cores busy.