From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 44674@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#44674: 28.0.50; Adding current-cpu-time for performance tests
Date: Mon, 16 Nov 2020 21:12:46 +0200 [thread overview]
Message-ID: <83ima5ru8h.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkTicT1zE1pbvwe-p+mA7L_6U=spe3zR4dSTNtA9vpvbvg@mail.gmail.com> (message from Philipp Stephani on Mon, 16 Nov 2020 19:31:47 +0100)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 16 Nov 2020 19:31:47 +0100
> Cc: 44674@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
>
> Am Mo., 16. Nov. 2020 um 18:17 Uhr schrieb Eli Zaretskii <eliz@gnu.org>:
> >
> > > From: Philipp Stephani <p.stephani2@gmail.com>
> > > Date: Mon, 16 Nov 2020 12:46:07 +0100
> > > Cc: 44674@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
> > >
> > > > Btw, once this goes in, how about making benchmark-run use it?
> > >
> > > benchmark-run measures walltime, not CPU time
> >
> > It does now, but we may want to change that.
>
> That would be a breaking change.
I could argue that it's a bugfix.
> > Does it really make
> > sense to "benchmark" something using elapsed time?
>
> Yes, the benchmarks I know all measure wall time. After all, that's
> what the user cares about.
??? On a system that is heavily loaded, and Emacs doesn't get an
execution unit close to 100% of the time, the wallclock time can be so
skewed as to defeat any meaningful measurements. E.g., imagine that
you are running a benchmark while (another version of) Emacs is being
built with "make -jN", with N large enough to make all the cores busy.
next prev parent reply other threads:[~2020-11-16 19:12 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 1:07 bug#44674: 28.0.50; Adding current-cpu-time for performance tests Stefan Monnier
2020-11-16 7:13 ` Philipp Stephani
2020-11-16 7:58 ` Eli Zaretskii
2020-11-16 8:18 ` Eli Zaretskii
2020-11-16 11:46 ` Philipp Stephani
2020-11-16 17:17 ` Eli Zaretskii
2020-11-16 18:31 ` Philipp Stephani
2020-11-16 19:12 ` Eli Zaretskii [this message]
2020-11-16 22:09 ` Lars Ingebrigtsen
2020-11-16 10:11 ` Mattias Engdegård
2020-11-16 10:40 ` Eli Zaretskii
2020-11-16 10:48 ` Philipp Stephani
2020-11-16 10:53 ` Mattias Engdegård
2020-11-16 17:15 ` Eli Zaretskii
2020-11-16 15:27 ` Stefan Monnier
2020-11-16 16:14 ` Mattias Engdegård
2020-11-16 17:28 ` Eli Zaretskii
2020-11-16 17:38 ` Eli Zaretskii
2020-11-16 17:59 ` Andreas Schwab
2020-11-16 18:27 ` Eli Zaretskii
2020-11-16 18:41 ` Stefan Monnier
2020-11-16 19:22 ` Eli Zaretskii
2020-11-16 18:32 ` Philipp Stephani
2020-11-16 19:17 ` Eli Zaretskii
2020-11-16 20:10 ` Stefan Monnier
2020-11-16 18:41 ` Stefan Monnier
2020-11-16 18:39 ` Philipp Stephani
2020-11-16 19:07 ` Stefan Monnier
2020-11-16 17:13 ` Eli Zaretskii
2020-11-16 19:15 ` Mattias Engdegård
2022-04-26 13:55 ` Lars Ingebrigtsen
2022-04-26 15:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-27 13:09 ` Lars Ingebrigtsen
2022-04-27 17:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-04-27 17:20 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ima5ru8h.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=44674@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).