From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#45198: 28.0.50; Sandbox mode Date: Thu, 31 Dec 2020 18:50:07 +0200 Message-ID: <83im8hhqdc.fsf@gnu.org> References: <838s9gk476.fsf@gnu.org> <834kk4k090.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32949"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bzg@gnu.org, 45198@debbugs.gnu.org, monnier@iro.umontreal.ca, joaotavora@gmail.com To: Philipp Stephani Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 31 17:51:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kv1AR-0008Jd-TL for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Dec 2020 17:51:15 +0100 Original-Received: from localhost ([::1]:36590 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kv1AQ-0003va-S4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Dec 2020 11:51:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40078) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kv1AE-0003vR-P7 for bug-gnu-emacs@gnu.org; Thu, 31 Dec 2020 11:51:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58159) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kv1AE-0005Tq-IR for bug-gnu-emacs@gnu.org; Thu, 31 Dec 2020 11:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kv1AE-0002ST-HA for bug-gnu-emacs@gnu.org; Thu, 31 Dec 2020 11:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Dec 2020 16:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45198 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 45198-submit@debbugs.gnu.org id=B45198.16094334409417 (code B ref 45198); Thu, 31 Dec 2020 16:51:02 +0000 Original-Received: (at 45198) by debbugs.gnu.org; 31 Dec 2020 16:50:40 +0000 Original-Received: from localhost ([127.0.0.1]:41472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kv19r-0002Rp-Ji for submit@debbugs.gnu.org; Thu, 31 Dec 2020 11:50:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kv19q-0002Rc-Qg for 45198@debbugs.gnu.org; Thu, 31 Dec 2020 11:50:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52260) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kv19j-0005E6-JV; Thu, 31 Dec 2020 11:50:33 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3077 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kv19i-00023j-9p; Thu, 31 Dec 2020 11:50:31 -0500 In-Reply-To: (message from Philipp Stephani on Thu, 31 Dec 2020 16:05:52 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197102 Archived-At: > From: Philipp Stephani > Date: Thu, 31 Dec 2020 16:05:52 +0100 > Cc: Stefan Monnier , Bastien , 45198@debbugs.gnu.org, > João Távora > > Am Di., 29. Dez. 2020 um 18:09 Uhr schrieb Eli Zaretskii : > > > > Because some/many Gnulib replacements are incompatible with how the > > w32 port of Emacs works. In particular, functions which operate on > > file names don't support UTF-8 encoded file names; Gnulib's 'stat' and > > 'fstat' don't support security-related features from which we glean > > owner and group of files; network-related functions need special > > handling in Emacs to support subprocess functionality; etc. > > That's a fair point, but does the mere presence of these replacements > really break the build? If the function compiles cleanly and is not used on MS-Windows, then no, the build won't break. > Could we somehow make them not break the build? It's not up to us, because we don't maintain Gnulib code. And it isn't always practical, since the Windows port of Emacs has its own replacements for some Posix functionality that conflict with the Gnulib replacements. > > I know; I wrote that. However, this talks about code that will be > > actually _used_ in the Windows build, whereas here we are talking > > about "ballast": the related code will not be used at all. So it > > makes sense not to make our job harder by adding unnecessary code, > > which then will need to be audited for compatibility. Your Gnulib > > import adds quite a lot of modules, which makes the audit a large job. > > Independent of this discussion, are there ways to reduce the size of > the auditing job? I'd hope that eventually the only thing needed would > be to run the test suite (which ideally would happen automatically on > Gitlab/Emba). The test suite is doesn't yet have enough coverage. And if Emacs fails to build, the test suite cannot help. > For developers not on Windows, it's unfortunately difficult to predict > whether a specific change will break the Windows build or not, and the > large difference between the Windows and other builds doesn't make > this easier. Sure, that's when posting a patch or a separate branch are a good means to let the code be fixed before it lands.