From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 19 Feb 2021 09:51:51 +0200 Message-ID: <83im6o4hrc.fsf@gnu.org> References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> <83k0r53ygd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10109"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 19 08:52:17 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD0aD-0002PX-Tv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 08:52:13 +0100 Original-Received: from localhost ([::1]:43606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD0aC-0002JQ-Tv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 02:52:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51356) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD0a2-0002Hl-QX for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 02:52:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD0a2-0000AZ-Ip for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 02:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lD0a2-0007dA-Hf for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 02:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 07:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, larsi@gnus.org, 43725@debbugs.gnu.org, monnier@iro.umontreal.ca Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.161372110829306 (code B ref 43725); Fri, 19 Feb 2021 07:52:02 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 19 Feb 2021 07:51:48 +0000 Original-Received: from localhost ([127.0.0.1]:48657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD0Zo-0007cb-ER for submit@debbugs.gnu.org; Fri, 19 Feb 2021 02:51:48 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33486) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD0Zm-0007cB-32 for 43725@debbugs.gnu.org; Fri, 19 Feb 2021 02:51:46 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:58287) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD0Zb-0008QX-W1; Fri, 19 Feb 2021 02:51:36 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4684 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lD0Zb-0007zQ-G5; Fri, 19 Feb 2021 02:51:35 -0500 In-Reply-To: (message from Andrea Corallo on Thu, 18 Feb 2021 20:53:05 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200306 Archived-At: > From: Andrea Corallo > Cc: bug-gnu-emacs@gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca, > 43725@debbugs.gnu.org > Date: Thu, 18 Feb 2021 20:53:05 +0000 > > >> comp.c:1174:22: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op] > >> 1174 | if (val > LONG_MAX || val < LONG_MIN) > >> | ^~ > >> > >> Not sure what's the best way to silence it or if we want to revert to > >> the previous formulation. > > Hi Eli, > > sorry just to make sure I understand the suggestions: > > > You can either condition that by WIDE_EMACS_INT, > > Put it under #ifdef I guess. > > > or add a comparison > between LONG_MAX and INT_MAX. > > Not sure I understand how you'd write this. Maybe it will be easier to do something like this instead: #if EMACS_INT_MAX > LONG_MAX return emit_rvalue_from_unsigned_long_long (... #else return gcc_jit_context_new_rvalue_from_long (... #endif Does that work well? Btw, why does the 'long long' variant say "unsigned", while the 'long' variant doesn't?