From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#43725: 28.0.50; Include feature/native-comp into master Date: Fri, 19 Feb 2021 15:37:52 +0200 Message-ID: <83im6o2n67.fsf@gnu.org> References: <87wny8xwcc.fsf@gnus.org> <83im9sqk1b.fsf@gnu.org> <83v9drp8va.fsf@gnu.org> <831rdjd95w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27167"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, monnier@iro.umontreal.ca, 43725@debbugs.gnu.org, akrl@sdf.org To: Pip Cet Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 19 14:38:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lD5z1-0006yV-T9 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 14:38:11 +0100 Original-Received: from localhost ([::1]:50464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD5z0-0001bv-Tw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Feb 2021 08:38:10 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46026) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD5ys-0001ZP-13 for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 08:38:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37409) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lD5yr-0007rW-PC for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 08:38:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lD5yr-0001Wr-Ma for bug-gnu-emacs@gnu.org; Fri, 19 Feb 2021 08:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Feb 2021 13:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43725 X-GNU-PR-Package: emacs Original-Received: via spool by 43725-submit@debbugs.gnu.org id=B43725.16137418705855 (code B ref 43725); Fri, 19 Feb 2021 13:38:01 +0000 Original-Received: (at 43725) by debbugs.gnu.org; 19 Feb 2021 13:37:50 +0000 Original-Received: from localhost ([127.0.0.1]:48955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD5yg-0001WN-7y for submit@debbugs.gnu.org; Fri, 19 Feb 2021 08:37:50 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lD5yc-0001W8-Ah for 43725@debbugs.gnu.org; Fri, 19 Feb 2021 08:37:48 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47233) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD5yV-0007it-Fb; Fri, 19 Feb 2021 08:37:39 -0500 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2239 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lD5yU-0002Y8-7O; Fri, 19 Feb 2021 08:37:38 -0500 In-Reply-To: (message from Pip Cet on Fri, 19 Feb 2021 12:53:43 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:200329 Archived-At: > From: Pip Cet > Date: Fri, 19 Feb 2021 12:53:43 +0000 > Cc: 43725@debbugs.gnu.org, eliz@gnu.org, larsi@gnus.org, > Stefan Monnier > > > comp.c:1174:22: warning: logical ‘or’ of collectively exhaustive tests is always true [-Wlogical-op] > > 1174 | if (val > LONG_MAX || val < LONG_MIN) > > | ^~ > > > > Not sure what's the best way to silence it or if we want to revert to > > the previous formulation. > > Maybe it's me, but I had a hard time parsing that warning. IIUC, the > tests are both trivially false? And oring two trivially false > conditions shouldn't trigger a warning, should it? No, I think it tries to say that val is always either greater than LONG_MAX or smaller than LONG_MIN. > Sounds like it's GCC that needs to be fixed. Could be. But I've given up on GCC's tendency to warn about perfectly valid programs.