From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message Date: Tue, 08 Jun 2021 21:12:10 +0300 Message-ID: <83im2ody4l.fsf@gnu.org> References: <87k0n8kl1h.fsf@mail.linkov.net> <83r1hfilfg.fsf@gnu.org> <875yyqlnml.fsf@mail.linkov.net> <83bl8hhnm7.fsf@gnu.org> <87wnr4b8p4.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26518"; mail-complaints-to="usenet@ciao.gmane.io" Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 08 20:13:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqgE2-0006nN-4S for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 20:13:18 +0200 Original-Received: from localhost ([::1]:53788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqgE1-0002bk-5f for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Jun 2021 14:13:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqgDn-0002b9-3h for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 14:13:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48216) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqgDm-0004O8-6D for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 14:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lqgDl-0002OJ-VR for bug-gnu-emacs@gnu.org; Tue, 08 Jun 2021 14:13:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Jun 2021 18:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48669 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48669-submit@debbugs.gnu.org id=B48669.16231759549156 (code B ref 48669); Tue, 08 Jun 2021 18:13:01 +0000 Original-Received: (at 48669) by debbugs.gnu.org; 8 Jun 2021 18:12:34 +0000 Original-Received: from localhost ([127.0.0.1]:59762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqgDK-0002Nc-84 for submit@debbugs.gnu.org; Tue, 08 Jun 2021 14:12:34 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:59144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lqgDI-0002NP-BE for 48669@debbugs.gnu.org; Tue, 08 Jun 2021 14:12:32 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42342) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqgDC-0004Cm-Ji; Tue, 08 Jun 2021 14:12:26 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4303 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqgDC-0002JE-3u; Tue, 08 Jun 2021 14:12:26 -0400 In-Reply-To: <87wnr4b8p4.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 08 Jun 2021 19:52:07 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:208256 Archived-At: > From: Juri Linkov > Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org > Date: Tue, 08 Jun 2021 19:52:07 +0300 > > >> If minibuffer--message-overlay-pos serves its purpose for > >> set-minibuffer-message, it seems suitable for > >> minibuffer-message as well. > > > > So you object to adding a comment there which would explain what that > > call does? > > Now I added a comment, and pushed to master. > > >> >> - (put-text-property 0 1 'cursor t message)) > >> >> + (put-text-property 0 1 'cursor 1 message)) > >> > > >> > Why this change? > >> > >> Only to make minibuffer-message the identical copy of > >> set-minibuffer-message. > > > > I'd say make it the other way around. Handling the 'cursor' property > > with a numeric value is more expensive and tricky than if the value is > > t, and in this case the effect is exactly the same. > > So I changed the 'cursor' property to t. Thank you.