From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org
Subject: bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message
Date: Tue, 08 Jun 2021 21:12:10 +0300 [thread overview]
Message-ID: <83im2ody4l.fsf@gnu.org> (raw)
In-Reply-To: <87wnr4b8p4.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 08 Jun 2021 19:52:07 +0300)
> From: Juri Linkov <juri@linkov.net>
> Cc: joca.bt@gmail.com, 48669@debbugs.gnu.org
> Date: Tue, 08 Jun 2021 19:52:07 +0300
>
> >> If minibuffer--message-overlay-pos serves its purpose for
> >> set-minibuffer-message, it seems suitable for
> >> minibuffer-message as well.
> >
> > So you object to adding a comment there which would explain what that
> > call does?
>
> Now I added a comment, and pushed to master.
>
> >> >> - (put-text-property 0 1 'cursor t message))
> >> >> + (put-text-property 0 1 'cursor 1 message))
> >> >
> >> > Why this change?
> >>
> >> Only to make minibuffer-message the identical copy of
> >> set-minibuffer-message.
> >
> > I'd say make it the other way around. Handling the 'cursor' property
> > with a numeric value is more expensive and tricky than if the value is
> > t, and in this case the effect is exactly the same.
>
> So I changed the 'cursor' property to t.
Thank you.
prev parent reply other threads:[~2021-06-08 18:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 12:50 bug#48669: Inconsistent overlay placement between minibuffer-message and set-minibuffer-message João Guerra
2021-05-31 20:24 ` Juri Linkov
2021-06-05 21:43 ` Juri Linkov
2021-06-06 5:58 ` Eli Zaretskii
2021-06-06 20:54 ` Juri Linkov
2021-06-07 12:21 ` Eli Zaretskii
2021-06-08 16:52 ` Juri Linkov
2021-06-08 18:12 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83im2ody4l.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=48669@debbugs.gnu.org \
--cc=joca.bt@gmail.com \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).