From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50630: [PATCH] Add tests for insert-directory Date: Sat, 25 Sep 2021 16:06:28 +0300 Message-ID: <83ilyorei3.fsf@gnu.org> References: <83a6k1rxrc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31294"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 50630@debbugs.gnu.org To: John Cummings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 25 15:07:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mU7OX-0007vw-Du for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 15:07:09 +0200 Original-Received: from localhost ([::1]:53348 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU7OW-00056G-5g for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Sep 2021 09:07:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57316) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU7OQ-00055l-2R for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 09:07:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48863) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mU7OP-00053d-RE for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 09:07:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mU7OP-0003ve-Jy for bug-gnu-emacs@gnu.org; Sat, 25 Sep 2021 09:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Sep 2021 13:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50630 X-GNU-PR-Package: emacs Original-Received: via spool by 50630-submit@debbugs.gnu.org id=B50630.163257520015062 (code B ref 50630); Sat, 25 Sep 2021 13:07:01 +0000 Original-Received: (at 50630) by debbugs.gnu.org; 25 Sep 2021 13:06:40 +0000 Original-Received: from localhost ([127.0.0.1]:60406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU7O4-0003ur-5U for submit@debbugs.gnu.org; Sat, 25 Sep 2021 09:06:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mU7O1-0003ub-R6 for 50630@debbugs.gnu.org; Sat, 25 Sep 2021 09:06:39 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:42644) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mU7Nw-0004cl-EF; Sat, 25 Sep 2021 09:06:32 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4787 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mU7Nv-0001F1-IT; Sat, 25 Sep 2021 09:06:32 -0400 In-Reply-To: (message from John Cummings on Sat, 25 Sep 2021 11:38:08 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:215440 Archived-At: > Date: Sat, 25 Sep 2021 11:38:08 +0000 > From: John Cummings > Cc: 50630@debbugs.gnu.org > > Eli Zaretskii wrote: > > >> Date: Fri, 24 Sep 2021 19:58:25 +0000 > >> From: John Cummings > >> > >> Along those lines, I also attempted to skip the test when ls-lisp > >> would be used during files-tests.el, which I predict might happen when > >> building on Windows? > > > > Why did you need to skip those tests? Can you elaborate? > > ls-lisp has its own implementation of insert-directory, which > duplicates the bug, and which will also duplicate the fix when I > submit it soon. Some context is probably lost here: which bug are you talking about? And if that bug will be fixed in ls-lisp, then why do you need to single ls-lisp out? > I admit I may not correctly or completely understand the way that > ls-lisp could relate to a batch ert run at build time, or how that > varies between architectures. Whenever you invoke insert-directory, on MS-Windows it will invoke ls-lisp. > I personally find the variable a little confusing, > and think that negating its name and meaning would be more natural, > but the documentation does make it clear, even if I have to think > about it for a bit every time I set it. You are talking about ls-lisp-use-insert-directory-program? Why it is confusing? ls-lisp by default doesn't use any programs, it accesses the files' attributes using Emacs Lisp APIs; so the "program" part is a reference to the fact that on Posix platforms insert-directory uses the 'ls' program instead.