From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#52018: 28.0.60; Improve documentation for compilation-finish-functions Date: Sun, 21 Nov 2021 21:25:59 +0200 Message-ID: <83ilwlqpiw.fsf@gnu.org> References: <871r39hjj3.fsf@thb.lt> <83sfvpr17k.fsf@gnu.org> <87wnl1gwc7.fsf@thb.lt> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22738"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52018@debbugs.gnu.org To: Thibault Polge Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 21 20:27:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mosUa-0005jJ-Fd for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 20:27:12 +0100 Original-Received: from localhost ([::1]:43764 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mosUZ-0001Qx-94 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 21 Nov 2021 14:27:11 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mosUQ-0001Ni-Lk for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 14:27:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34509) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mosUQ-0004Ll-D2 for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 14:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mosUQ-0004ZO-A2 for bug-gnu-emacs@gnu.org; Sun, 21 Nov 2021 14:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Nov 2021 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52018 X-GNU-PR-Package: emacs Original-Received: via spool by 52018-submit@debbugs.gnu.org id=B52018.163752276317490 (code B ref 52018); Sun, 21 Nov 2021 19:27:02 +0000 Original-Received: (at 52018) by debbugs.gnu.org; 21 Nov 2021 19:26:03 +0000 Original-Received: from localhost ([127.0.0.1]:46055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mosTS-0004Y1-Pc for submit@debbugs.gnu.org; Sun, 21 Nov 2021 14:26:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mosTR-0004XY-Hq for 52018@debbugs.gnu.org; Sun, 21 Nov 2021 14:26:01 -0500 Original-Received: from [2001:470:142:3::e] (port=60372 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mosTK-0003x1-Ko; Sun, 21 Nov 2021 14:25:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aoNw6D5lYP9sI258bT6KiPj91ESx42w+iLObPcsPctY=; b=gBKzdtuPSgBV 5fvKe8ix1g2AbfMi3RlwCLltVLAMlzyIrmFdxKhXBLFtncM66kjQaZLQJSLNrh4g+qTMlY0vgtQV3 ji/e2ziLaKpi+OGO/vYE4k6ltZ7RWx8Me67+2QX4ZNeLt2DACPIZQqitFvr6hwJpRPT+OCOAjFRWx 8D+i6ZdgaH7GHGCKPoJ+P1a9oLScOjHlXRlr+mlzb93db/VeVQetxnRav1GWhfVS0wssQhOnTLSiQ KhA23cUC8v35IoU54RFRnCa6HWVvvy9nQ9kxFf8mMzG8KdLR5+Txtu16BINY/lCKFVTOXQDgy/r22 yhMxUgEp8YfHaj2Iko0jBA==; Original-Received: from [87.69.77.57] (port=1151 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mosTJ-0003uy-VV; Sun, 21 Nov 2021 14:25:54 -0500 In-Reply-To: <87wnl1gwc7.fsf@thb.lt> (message from Thibault Polge on Sun, 21 Nov 2021 20:08:56 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220585 Archived-At: > From: Thibault Polge > Cc: 52018@debbugs.gnu.org > Date: Sun, 21 Nov 2021 20:08:56 +0100 > > (force-mode-line-update) > [...] > (run-hook-with-args 'compilation-finish-functions cur-buffer msg))) > > So the msg that compilation-handle-exit receives is passed, unmodified, > to all 'compilation-finish-functions`. Maybe so, but I'm looking at the calls of compilation-handle-exit, and the callers do all kinds of transformations with the original status, so I think documenting what happens to be more-or-less correct now is fragile. Why do you think this addition is of such great importance to have it spelled out in the doc string?