From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51883: 29.0.50; Command to get accidentally deleted frames back Date: Sun, 30 Jan 2022 18:59:14 +0200 Message-ID: <83ilu19n31.fsf@gnu.org> References: <87czn1gfb1.fsf@web.de> <838rxo0zk7.fsf@gnu.org> <86czk9kxm8.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31854"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, gregory@heytings.org, monnier@iro.umontreal.ca, 51883@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 30 18:02:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEDae-0008Au-Nq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 18:02:12 +0100 Original-Received: from localhost ([::1]:54266 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEDac-0004sZ-03 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 12:02:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEDYZ-0004p2-EZ for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 12:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44602) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEDYZ-00079K-4c for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 12:00:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEDYY-0005xe-V3 for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 12:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jan 2022 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51883 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51883-submit@debbugs.gnu.org id=B51883.164356197022836 (code B ref 51883); Sun, 30 Jan 2022 17:00:02 +0000 Original-Received: (at 51883) by debbugs.gnu.org; 30 Jan 2022 16:59:30 +0000 Original-Received: from localhost ([127.0.0.1]:37505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEDY2-0005wF-J3 for submit@debbugs.gnu.org; Sun, 30 Jan 2022 11:59:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEDXy-0005w0-NF for 51883@debbugs.gnu.org; Sun, 30 Jan 2022 11:59:30 -0500 Original-Received: from [2001:470:142:3::e] (port=50048 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEDXt-00070J-4z; Sun, 30 Jan 2022 11:59:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gG2G6/SX/fEwD/UGWqg0oJgC6tdrtQ8uOSg7GUkhyaw=; b=NX5ysGQXq80x njGQFB2rXHoPyoSlj+SqlVtXl9CJ25XOxuxETB9JeIbw2EnSIv8K2nr69Oc/8JiKlv07y0mpcGU49 B3Kh0j+eLG2OhDjyQONYR2EF2sT77mxeQ4ZHN6hzVRJadPtbZYJ9MRdjk0bE5Pat5PJEwmQuXJRks COC2KbImg5yY3mrk3Io56H8U1stSKDqydBuUa+iKYn35IYLSCWzf4a8UwJ5ZyD7B2sDJRHGWTX801 pWlj3bk+uPXcj43KZGLRB9tbOTRRSWYHQGRcjV/yfrbSX6rm0KYx9whojb6ZcYSEBFyv6uYT0P654 uh37nwtbiwdWfSigHQOrUw==; Original-Received: from [87.69.77.57] (port=2003 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEDXs-0005XK-JW; Sun, 30 Jan 2022 11:59:20 -0500 In-Reply-To: <86czk9kxm8.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 30 Jan 2022 18:39:16 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225615 Archived-At: > From: Juri Linkov > Cc: Eli Zaretskii , michael_heerdegen@web.de, Gregory Heytings > , 51883@debbugs.gnu.org > Date: Sun, 30 Jan 2022 18:39:16 +0200 > > So all concerns raised by Eli are addressed now > that make possible to enable it by default > as was discussed on emacs-devel: Once again, please do NOT enable this by default, I didn't agree to that. This feature should remain disabled by default for some time, until we have enough information to discuss whether it should be turned on by default. As discussed and agreed during its development. > @item C-x 5 u > @kindex C-x 5 u > @findex undelete-frame > -@findex undelete-frame-mode > -When @code{undelete-frame-mode} is enabled, undelete one of the 16 > -most recently deleted frames. Without a prefix argument, undelete the > -most recently deleted frame. With a numerical prefix argument between > -1 and 16, where 1 is the most recently deleted frame, undelete the > -corresponding deleted frame. > +@findex undelete-frame-max > +Undelete one of the recently deleted frames. The user option "One of the recently deleted frames" sounds like Emacs arbitrarily decides which one. Which is not what you wanted to say, surely. > +(defcustom undelete-frame-max 1 > + "Maximum number of deleted frames before oldest are thrown away." This doesn't say how to disable the feature. > (bindings--define-key menu [undelete-last-deleted-frame] > '(menu-item "Undelete Frame" undelete-frame > - :enable (and undelete-frame-mode > - (car undelete-frame--deleted-frames)) > + :visible (car undelete-frame--deleted-frames) I think Gregory didn't like the disappearing item, and preferred it to be visible at all times, even if disabled.