bug#54156: 28.0.91; set-face-attribute with a nil FRAME doesn't change the default

[Eli Zaretskii <eliz@gnu.org>]

> From: Damien Cassou <damien@cassou.me>
> Date: Fri, 25 Feb 2022 11:21:45 +0100
> 
> I have this in my init.el file:
> 
> (set-face-attribute 'finsit-javascript-html-tag-face nil :background nil)
> 
> As you can see, the FRAME argument (the 2nd) is nil. The documentation
> says: "If FRAME is nil, set the attributes for all existing frames, as
> well as the default for new frames.".
> 
> However, when creating a new frame the background of this face is
> reset and I have to execute this line manually.

Please show a complete recipe for reproducing the problem, starting
from "emacs -Q".  In particular, we need to see:

  . how that face was defined in the first place (defface or somesuch)
  . how you create a new frame

> Workaround:
> 
>   (defun my/fix-finsit-javascript-html-tag-face ()
>     "Remove the background of `finsit-javascript-html-tag-face'."
>     (set-face-attribute 'finsit-javascript-html-tag-face nil :background nil))
> 
>   (add-hook 'server-after-make-frame-hook #'my/fix-finsit-javascript-html-tag-face)

Since you set 'server-after-make-frame-hook', does this mean the
problem happens only with emacsclient frames?  If so, that is one more
reason for providing a complete recipe for us to investigate.

Thanks.