From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54190: 29.0.50; [PATCH] Incorrect/missing documentation for some Eshell "$" syntaxes Date: Tue, 01 Mar 2022 15:10:51 +0200 Message-ID: <83ilsxlsx0.fsf@gnu.org> References: <0c3898ff-23ac-51bc-2211-770302d7d00e@gmail.com> <06a184d5-b191-4c63-a851-13d1c8c18eda@gmail.com> <1dfa575b-bf3f-84ca-b7b5-a612ffc57737@gmail.com> <87o82rqqjs.fsf@gnus.org> <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23733"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 54190@debbugs.gnu.org, monnier@iro.umontreal.ca To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 01 14:12:38 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP2Iw-00064Y-0j for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Mar 2022 14:12:38 +0100 Original-Received: from localhost ([::1]:46214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nP2Iv-0006wa-1r for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 01 Mar 2022 08:12:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50464) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP2IM-0006wH-7V for bug-gnu-emacs@gnu.org; Tue, 01 Mar 2022 08:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41961) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nP2IL-0007mq-U4 for bug-gnu-emacs@gnu.org; Tue, 01 Mar 2022 08:12:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nP2IL-0001tD-K6 for bug-gnu-emacs@gnu.org; Tue, 01 Mar 2022 08:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Mar 2022 13:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54190 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54190-submit@debbugs.gnu.org id=B54190.16461402697198 (code B ref 54190); Tue, 01 Mar 2022 13:12:01 +0000 Original-Received: (at 54190) by debbugs.gnu.org; 1 Mar 2022 13:11:09 +0000 Original-Received: from localhost ([127.0.0.1]:35856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP2HV-0001s1-0O for submit@debbugs.gnu.org; Tue, 01 Mar 2022 08:11:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nP2HQ-0001rE-Iy for 54190@debbugs.gnu.org; Tue, 01 Mar 2022 08:11:08 -0500 Original-Received: from [2001:470:142:3::e] (port=34214 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP2HL-0007Wm-BU; Tue, 01 Mar 2022 08:10:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VH0zm9e6LWZ3hvZOt+mjVj/ljoJxtjspYY+O8v7iIVg=; b=b4/xcW9Y9oRR HhBLHaBNnkoied7v6DV1td/lxF6TxXwlpk5wbQm+uAUPHAQrVO8QBNONIAIY1xJ4hr5w3wrzimMoI M1F6h8xYtS20t2O4YGUDgVzGtFb4JFq72FgrH1nQHorZAkKBTlxuS4IFrquxvmVnzPAo1zF/V7/rB xo+CvhKLtPRu8pjUrbYeVqvGiWsdf8a5c7FZthHQWAYeX+657kA0M9dkQ+bD/twY7wVGyAYFIYSR9 wmWk2uQ4RG9ccg39WsQIMACJzHq+CDh99/z9lo78q5NWDy30s3rMMPaqMoMzpgHcfi2qo6LzgX1A4 XhMC2+BeaMTedPFOl+SbTw==; Original-Received: from [87.69.77.57] (port=1215 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nP2HJ-0006ES-Rc; Tue, 01 Mar 2022 08:10:59 -0500 In-Reply-To: <1a23eafb-d856-5e31-9d98-03187a896fc8@gmail.com> (message from Jim Porter on Mon, 28 Feb 2022 09:47:54 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227862 Archived-At: > From: Jim Porter > Date: Mon, 28 Feb 2022 09:47:54 -0800 > Cc: 54190@debbugs.gnu.org > > Here's a patch to fix this, with a test so it doesn't regress again. I > also re-attached the doc fix for simplicity. Both should apply to the 28 > branch with no issues. Thanks, installed on the emacs-28 branch. (But the markup in the manual part was wrong; see my followup changes.) > I'll try to figure out why `eshell-do-eval' expects quoted lambdas, but > unless that's a really trivial problem, the method here is probably > safer for the 28 branch. Besides, I'm now 4 or 5 steps removed from the > patch I was *trying* to work on, so a quick fix here will help me get > back on track. > > Longer term, I agree that rewriting `eshell-do-eval' in terms of > generator.el would be good. I think there are some bugs with how local > variable state is managed by `eshell-do-eval', but I haven't had a > chance to investigate it in any detail yet. Fine with me. It's up to you whether to close this bug or leave it open until a better solution is found for master.