unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Baums <baums@stefanbaums.com>
Cc: 55539@debbugs.gnu.org
Subject: bug#55539: 28.1; Support for the Kharoṣṭhī Script
Date: Fri, 20 May 2022 19:18:45 +0300	[thread overview]
Message-ID: <83ilq09nyy.fsf@gnu.org> (raw)
In-Reply-To: <87mtfcsffk.fsf@stefanbaums.com> (message from Stefan Baums on Fri, 20 May 2022 11:48:15 +0200)

> From: Stefan Baums <baums@stefanbaums.com>
> Date: Fri, 20 May 2022 11:48:15 +0200
> 
> Please find attached the necessary code for inclusion in Emacs 29.
> The file “kharoshthi.el” is for the lisp/language folder, the file
> “kharoshthi-input.el” (to be renamed to simple “kharoshthi.el”)
> for the lisp/leim/quail folder.

Thanks, please see a few comments below.

> ;;; kharoshthi.el --- support for the Kharoṣṭhī script

Please place this part in lisp/language/misc.el, not on a separate
file.

> (let ((consonant     "[\U00010A00\U00010A10-\U00010A35]")
>       (vowel         "[\U00010A01-\U00010A06]")
>       (virama        "\U00010A3F")
>       (modifier      "[\U00010A0C-\U00010A0F\U00010A38-\U00010A3A]"))
>   (set-char-table-range composition-function-table
> 		                ;; '(#x10A00 . #x10A5F)

This last line should be removed, no?

> 		                '(#x10A3F . #x10A3F)
>                         (list
>                          (vector
>                           (concat consonant
>                                   "\\(?:" virama consonant "\\)*"
>                                   modifier "*"
>                                   virama "?"
>                                   vowel "*"
>                                   modifier "*")
>                           1 'font-shape-gstring))))

Note that according to the rule above, a sequence

  consonant modifier vowel

will not be composed, although it matches the regexp, because its
second character is not a virama.  Is this okay?

> (quail-define-package
>  "kharoshthi" "Kharoṣṭhī" "𐨑" nil
>  "Kharoṣṭhī input method." nil t t t t nil nil nil nil nil t)
> 
> (quail-define-rules
> 
>  ("a" ["𐨀"]) ("i" ["𐨀𐨁"]) ("u" ["𐨀𐨂"]) ("R" ["𐨀𐨃"]) ("e" ["𐨀𐨅"]) ("o" ["𐨀𐨆"])

Can you please reformat this to have just one rule per line?  It will
make that easier to read and maintain.

Last, but not least: these changes are too large for us to accept
without a copyright assignment.  Would you be willing to start the
legal paperwork of the copyright assignment at this time?  If yes, I
will send you the form to fill and the instructions to email the form.

Thank you for your interest in Emacs.





  reply	other threads:[~2022-05-20 16:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20  9:48 bug#55539: 28.1; Support for the Kharoṣṭhī Script Stefan Baums
2022-05-20 16:18 ` Eli Zaretskii [this message]
2022-05-20 17:16   ` Stefan Baums
2022-05-20 17:27     ` Eli Zaretskii
2022-05-20 18:05     ` Stefan Baums
2022-05-31 13:47     ` Eli Zaretskii
2022-06-05 16:55       ` Stefan Baums
2022-06-05 16:58         ` Eli Zaretskii
2022-06-05 17:18           ` Stefan Baums
2022-06-05 17:52             ` समीर सिंह Sameer Singh
2022-06-05 18:45               ` Stefan Baums
2022-06-08 13:29                 ` समीर सिंह Sameer Singh
2022-06-08 18:42                   ` Stefan Baums
2022-06-09  4:59                     ` Eli Zaretskii
2022-06-09  9:40                       ` Stefan Baums
2022-06-09 10:17                         ` Eli Zaretskii
2022-06-09  9:14             ` Eli Zaretskii
2022-06-09  9:52               ` Stefan Baums
2022-06-09  9:56                 ` Stefan Baums
2022-06-09 10:29                 ` Eli Zaretskii
2022-06-09 10:37                   ` Stefan Baums
2022-05-20 17:26   ` Stefan Baums

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ilq09nyy.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55539@debbugs.gnu.org \
    --cc=baums@stefanbaums.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).