unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Mackenzie <acm@muc.de>
Cc: info@protesilaos.com, larsi@gnus.org, 55414@debbugs.gnu.org
Subject: bug#55414: 29.0.50; Byte compilation error for the modus-themes
Date: Sun, 22 May 2022 16:25:23 +0300	[thread overview]
Message-ID: <83ilpx7l8c.fsf@gnu.org> (raw)
In-Reply-To: <Yoo2PGHtNFF6rDp8@ACM> (message from Alan Mackenzie on Sun, 22 May 2022 13:10:20 +0000)

> Date: Sun, 22 May 2022 13:10:20 +0000
> Cc: Protesilaos Stavrou <info@protesilaos.com>, larsi@gnus.org,
>   55414@debbugs.gnu.org
> From: Alan Mackenzie <acm@muc.de>
> 
> There are actually two (or maybe several) pairs of default values for
> max-lisp-eval-depth and max-specpdl-size.  They are set in src/eval.c in
> init_eval_once.  For when native compilation is enabled the defaults are
> 1600/2500.  When it's not, they're 800/1800.
> 
> modus-themes needs just short of 3000/3000, presumably when native
> compilation is enabled.
> 
> How about setting both pairs of defaults to 3000/3000 (i.e. no longer
> distinguishing between native compilation being set or not), and closing
> the bug?

That's too much an increase for the non-native compilation, IMO.

> It is, in any case, our medium term goal to have native
> compilation enabled by default.

How does the default value affect this?  I don't want to make the
values too large for the reasons I've explained up-thread (and you
agreed, AFAIU).

Do we know what value is necessary for modus-themes to successfully
byte-compile?  If so, let's increase the value separately for each
case: byte compilation and native-compilation.

> I'm still not very clear on the disadvantages of increasing
> max-lisp-eval-depth and max-specpdl-size substantially (say by 50% or
> 100%, not by a factor of 10 or so).  There are quite a lot of libraries
> (maybe the order of 10) which have their own (increased) values for one
> or both of these limit variables.  I don't see why it wouldn't be
> beneficial to use larger defaults, and purge these "private" settings.

Once again, the benefit was explained up-thread: we get to detect
infinite recursion sooner, faster, and more reliably.  With that in
mind, I cannot understand why you are lobbying for significant
increase in these values.





  reply	other threads:[~2022-05-22 13:25 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-14 18:07 bug#55414: 29.0.50; Byte compilation error for the modus-themes Protesilaos Stavrou
2022-05-15 13:45 ` Lars Ingebrigtsen
     [not found]   ` <87lev296hl.fsf@protesilaos.com>
2022-05-15 15:16     ` Lars Ingebrigtsen
2022-05-16  7:58       ` Alan Mackenzie
2022-05-16  8:21         ` Protesilaos Stavrou
2022-05-16 11:15         ` Eli Zaretskii
2022-05-16 12:03           ` Alan Mackenzie
2022-05-16 12:26             ` Eli Zaretskii
2022-05-16 13:48               ` Alan Mackenzie
2022-05-16 13:56                 ` Eli Zaretskii
2022-05-16 14:52                   ` Protesilaos Stavrou
2022-05-16 15:56                     ` Eli Zaretskii
2022-05-22 13:10                       ` Alan Mackenzie
2022-05-22 13:25                         ` Eli Zaretskii [this message]
2022-05-23  3:51                           ` Protesilaos Stavrou
2022-05-23 10:57                             ` Eli Zaretskii
2022-05-24  4:37                               ` Protesilaos Stavrou
2022-05-24 11:09                                 ` Eli Zaretskii
2022-05-25  3:24                                   ` Protesilaos Stavrou
2022-05-25 13:12                                     ` Eli Zaretskii
2022-05-26  5:55                                       ` Protesilaos Stavrou
2022-05-26 11:32                                         ` Eli Zaretskii
2022-05-26 11:57                                           ` Lars Ingebrigtsen
2022-05-26 12:59                                             ` Eli Zaretskii
2022-05-26 15:20                                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-26 15:42                                               ` Protesilaos Stavrou
2022-05-27  9:52                                             ` Alan Mackenzie
2022-05-27 10:25                                               ` Lars Ingebrigtsen
2022-05-26 16:02               ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-05-26 15:30 ` Mattias Engdegård
2022-05-27  9:03   ` Mattias Engdegård
2022-05-27 10:23     ` Lars Ingebrigtsen
2022-05-27 10:39       ` Protesilaos Stavrou
2022-05-27 10:42         ` Lars Ingebrigtsen
2022-05-27 11:32           ` Alan Mackenzie
2022-05-27 11:52             ` Lars Ingebrigtsen
2022-05-27 13:42               ` Alan Mackenzie
2022-05-27 13:50                 ` Lars Ingebrigtsen
2022-05-28 23:13                   ` Richard Stallman
2022-05-27 12:15             ` Protesilaos Stavrou
2022-05-27 13:59   ` Alan Mackenzie
2022-05-27 16:53     ` Mattias Engdegård
2022-05-27 18:24       ` Alan Mackenzie
2022-05-29  9:18         ` Mattias Engdegård
2022-05-29 13:38           ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ilpx7l8c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=55414@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=info@protesilaos.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).