From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#56809: file-name-with-extension: Improve docstring. Date: Thu, 28 Jul 2022 10:49:16 +0300 Message-ID: <83ilnhad8j.fsf@gnu.org> References: <87edy5929v.fsf@cassou.me> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12772"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 56809@debbugs.gnu.org To: Damien Cassou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 28 10:03:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGyUk-00038S-LS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jul 2022 10:03:46 +0200 Original-Received: from localhost ([::1]:54104 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oGyUf-0004cK-D2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Jul 2022 04:03:41 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGyHT-0007bU-BQ for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 03:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39520) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oGyHS-0000FJ-Vf for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 03:50:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oGyHS-0003tl-N1 for bug-gnu-emacs@gnu.org; Thu, 28 Jul 2022 03:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Jul 2022 07:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56809-submit@debbugs.gnu.org id=B56809.165899456114898 (code B ref 56809); Thu, 28 Jul 2022 07:50:02 +0000 Original-Received: (at 56809) by debbugs.gnu.org; 28 Jul 2022 07:49:21 +0000 Original-Received: from localhost ([127.0.0.1]:57498 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGyGm-0003sB-C0 for submit@debbugs.gnu.org; Thu, 28 Jul 2022 03:49:21 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oGyGg-0003ru-CP for 56809@debbugs.gnu.org; Thu, 28 Jul 2022 03:49:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45604) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGyGa-00088X-05; Thu, 28 Jul 2022 03:49:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BS6RE214RSmpeuboykNBgApxgwU2CoRfKBLTbI/ajT4=; b=BR0qhJ80YQ5l 7M58DHQsYHozAx2HUE1C3KgkIuyIqU4JQFKUyS6Rjc/U0kE8zul3l8Cy/ondvzmd2C/ZXMrKTJ19P i/3tF3BZzhZc4YK+Lcg/r8w6fH0FLVeRJp0mQhmgtZf5TEU1BFu5al8Yz1AzURC377TW/FCPwscI0 FztD/H7U+eeuBB4y/d9H27GWxQ762QBb7lElh00Q9/0G2zrXxHb3NHn6xem1anXCpAQoY0OXTIjCl 49QK7AFam7KcLRitWn8RjAo8p+TZQVfINRQUmltF9HwQVcevkkuRFNYMaISMyF37UpdGBlXBcr477 VwEKWp/QpknLxR3iJEmiQw==; Original-Received: from [87.69.77.57] (port=2121 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oGyGZ-0003Fq-AP; Thu, 28 Jul 2022 03:49:07 -0400 In-Reply-To: <87edy5929v.fsf@cassou.me> (message from Damien Cassou on Thu, 28 Jul 2022 08:31:24 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:238079 Archived-At: > From: Damien Cassou > Date: Thu, 28 Jul 2022 08:31:24 +0200 > > I found the docstring of file-name-with-extension very confusing so I > wrote another one. Thanks. It definitely needed its wording and its grammar fixed. I've now fixed that on the emacs-28 release branch. The modified doc string says this: "Return FILENAME modified to have the specified EXTENSION. The extension (in a file name) is the part that begins with the last \".\". This function removes any existing extension from FILENAME, and then appends EXTENSION to it. EXTENSION may include the leading dot; if it doesn't, this function will provide it. It is an error if FILENAME or EXTENSION is empty, or if FILENAME is in the form of a directory name according to `directory-name-p'. See also `file-name-sans-extension'." Looks OK?