unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Gabriel <gabriel376@hotmail.com>, Karl Fogel <kfogel@red-bean.com>
Cc: 59212@debbugs.gnu.org
Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type
Date: Sat, 12 Nov 2022 11:03:39 +0200	[thread overview]
Message-ID: <83iljko87o.fsf@gnu.org> (raw)
In-Reply-To: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@SJ0PR06MB8609.namprd06.prod.outlook.com> (message from Gabriel on Sat, 12 Nov 2022 05:56:22 -0300)

> From: Gabriel <gabriel376@hotmail.com>
> Date: Sat, 12 Nov 2022 05:56:22 -0300
> 
> Description:
> Not a bug per se, but a suggestion for improvement in how Bookmark
> displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659).
> 
> Currently, bookmark-bmenu-list (C-x r l) displays a column named Type,
> which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc)
> except for regular files, in which an empty string is displayed. I
> believe the current behavior could be improved by displaying a default
> value ("Files") to make the interface more uniform, explicit and to
> avoid confusion.
> 
> Steps:
> 1) emacs -Q
> 2) M-x eshell
> 3) C-x r m <RET>
> 4) C-x C-f ~/foo.bar
> 5) C-x r m <RET>
> 6) C-x r b
> 
> These steps will add two bookmarks (eshell and foo.bar) and will open
> the Bookmarks list. The Type column will have values "" and
> "Eshell". After the patch below is applied, the Type column will have
> values "File" and "Eshell".

Thanks.

Karl, any comments?





  reply	other threads:[~2022-11-12  9:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-12  8:56 bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type Gabriel
2022-11-12  9:03 ` Eli Zaretskii [this message]
2022-11-12 10:10   ` Stefan Kangas
2022-11-12 20:55     ` Gabriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83iljko87o.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59212@debbugs.gnu.org \
    --cc=gabriel376@hotmail.com \
    --cc=kfogel@red-bean.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).