From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists Date: Fri, 25 Nov 2022 13:55:34 +0200 Message-ID: <83ilj3uu2x.fsf@gnu.org> References: <87wn7ujpdh.fsf@web.de> <83edtz84wl.fsf@gnu.org> <87pmdctsf8.fsf@web.de> <83edtswi35.fsf@gnu.org> <87fse8tona.fsf@web.de> <83cz9cwg5z.fsf@gnu.org> <87bkowtmmr.fsf@web.de> <83a64gwfhv.fsf@gnu.org> <877czktlvr.fsf@web.de> <838rk0wak3.fsf@gnu.org> <87wn7jfjrg.fsf@web.de> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6647"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, jonas@bernoul.li, 59328@debbugs.gnu.org To: Michael Heerdegen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 12:56:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyXJm-0001V4-3f for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 12:56:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyXJU-00022p-9V; Fri, 25 Nov 2022 06:56:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyXJL-0001yV-DW for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 06:56:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyXJJ-0003qU-QL for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 06:56:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyXJJ-0000uw-N4 for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 06:56:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 11:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59328 X-GNU-PR-Package: emacs Original-Received: via spool by 59328-submit@debbugs.gnu.org id=B59328.16693773403499 (code B ref 59328); Fri, 25 Nov 2022 11:56:01 +0000 Original-Received: (at 59328) by debbugs.gnu.org; 25 Nov 2022 11:55:40 +0000 Original-Received: from localhost ([127.0.0.1]:33768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyXIy-0000uM-43 for submit@debbugs.gnu.org; Fri, 25 Nov 2022 06:55:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyXIv-0000u8-ME for 59328@debbugs.gnu.org; Fri, 25 Nov 2022 06:55:38 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyXIo-0003h7-Tb; Fri, 25 Nov 2022 06:55:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wvLry783UEyeQkVwcWdCGvYI+Waqi7huXNc9dibQY1E=; b=msRJdZ9ArnnQ I6SJkSQGuTEMIp7K0lBEryPeyNhecjsb6iwpLJ3ccGG/tO2bwrJPy6rCETJMbJJtN6zc9+aYY9796 jKCAe9Dd2Qz/TLsmpLutuvxdFMwqo9Q8UxZqBBYlBpdMtboRl2WmzSOq6OoNvJaSKMVTvyhcAF2p4 wsSdr382OsIm91XYMEdddhHRPYHXdvPvhCYJVLJJ1TQZm9ZHblaGZwY6sMXNUltDQduVp16o8XoBF ArqxZQQIpnk5Pjsuzq6DL8o42vUVZ08ta4kfXI4J+I29OiLRnq1vdiNbGm0uQvgahcc01x5wa9eU+ IlJSP16FrUs2SfyigVQPRA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyXIW-00069N-T7; Fri, 25 Nov 2022 06:55:21 -0500 In-Reply-To: <87wn7jfjrg.fsf@web.de> (message from Michael Heerdegen on Fri, 25 Nov 2022 10:47:31 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248992 Archived-At: > From: Michael Heerdegen > Cc: 59328@debbugs.gnu.org, larsi@gnus.org, jonas@bernoul.li > Date: Fri, 25 Nov 2022 10:47:31 +0100 > > Eli Zaretskii writes: > > > Can tests for this be written in a way that they are only run if the > > relevant packages are available on the user's system? If so, I'd > > prefer to have that than no tests at all. > > I don't know. AFAIK, 'require' can return nil if asked not to error out. > Alternatively we could implement `seq-map' for an ad-hoc defined > sequence type and test using that type, e.g. this expression: > > #+begin_src emacs-lisp > (progn > (defvar gensym) > (let ((gensym (make-symbol "foo"))) > (eval `(cl-defmethod seq-map (function (thing (head ,gensym))) > (append (list (car thing) (cadr thing)) (seq-map function (cddr thing)))) > t) > (equal (list gensym nil 4 46) > (seq-keep (lambda (x) (and (integerp x) (* 2 x))) > (list gensym nil 2 'x gensym 23))))) > #+end_src > > returns t with my patch installed and nil else and works without relying > on something external. I'm not sure if defining methods (for seq-map in > this case) that are globally visible is allowed in tests, so I > implemented the example above in a way that the change of the generic > function is not visible from the outside (thus the "secret" gensym). > > Would something like that be acceptable? > > Sorry for my ignorance, I didn't write much tests before. Sounds like over-engineering to me. Like I said: it's your call. If you see too many complications to adding a test, and my suggestions don't convince you, I won't object to installing your original proposal without a test. Thanks.