From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Date: Tue, 29 Nov 2022 14:14:48 +0200 Message-ID: <83iliylzyf.fsf@gnu.org> References: <87tu2wlku7.fsf@elite.giraud> <878rk8ee6d.fsf@yahoo.com> <8735agr0g4.fsf@elite.giraud> <83o7t4bhk4.fsf@gnu.org> <87zgcov1ps.fsf@elite.giraud> <8335agbai5.fsf@gnu.org> <875yfcuw5r.fsf@elite.giraud> <83r0y09td6.fsf@gnu.org> <87zgcotbw9.fsf@elite.giraud> <83iljc9k5s.fsf@gnu.org> <871qpt7hac.fsf@elite.giraud> <83y1s1y3vg.fsf@gnu.org> <87fse7jd7t.fsf@elite.giraud> <8735a7jczf.fsf@elite.giraud> <8335a5ubgr.fsf@gnu.org> <87sfi5aaph.fsf@elite.giraud> <834julsjjz.fsf@gnu.org> <87r0xpw77m.fsf@yahoo.com> <83h6ykrjc1.fsf@gnu.org> <871qpnkny2.fsf@ledu-giraud.fr> <87a64awpr8.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9685"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59351@debbugs.gnu.org, manuel@ledu-giraud.fr To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 29 13:33:49 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozzo4-0002FK-V3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Nov 2022 13:33:49 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozzWE-0005GG-CF; Tue, 29 Nov 2022 07:15:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozzVw-0005DP-TW for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 07:15:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozzVu-0004vB-Lm for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 07:15:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ozzVu-0007wp-Ie for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 07:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2022 12:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59351-submit@debbugs.gnu.org id=B59351.166972406530500 (code B ref 59351); Tue, 29 Nov 2022 12:15:02 +0000 Original-Received: (at 59351) by debbugs.gnu.org; 29 Nov 2022 12:14:25 +0000 Original-Received: from localhost ([127.0.0.1]:54358 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozzVJ-0007vs-8c for submit@debbugs.gnu.org; Tue, 29 Nov 2022 07:14:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ozzVG-0007vY-0p for 59351@debbugs.gnu.org; Tue, 29 Nov 2022 07:14:23 -0500 Original-Received: from fencepost.gnu.org ([209.51.188.10]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozzVA-0004lF-6E; Tue, 29 Nov 2022 07:14:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0MoNCKx2wIULbzc5bZLoFSYQZoLKa31JCYfJRMaJOYM=; b=CyX2nwVA+93x JeuUdT6w+ZCwF+6+AgKWwJpiDFTB/2a2WLJBUxtar1vpVuvYLa9YMNdarBW/NBOQkdSxLD5zedstb tMQY0m8br0hwNvTLFBNulWiKIJ7VUJGm0pAqbSCWvUjRnJC6kfk5t/1bFTY1faJ0w8+wbNLvCGYIb Y8n94NYt+yTB1Uscz46WULBz6Ttlcze3xg61PLJgNtUO5/lvAQENQqNCfDP+2eUoEonf+N3nwnQEU xkdyTrpXfFapxkqMXQ8HVvHWObZDJAuhLeajNfVRDo7ViOOSNNm5iwV4ip4B24ueT9PPO1eYVZvCd djWlbMRkyUZL/b/SYQ9vQg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozzV9-0002pR-Fn; Tue, 29 Nov 2022 07:14:15 -0500 In-Reply-To: <87a64awpr8.fsf@yahoo.com> (message from Po Lu on Tue, 29 Nov 2022 08:47:23 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249387 Archived-At: > From: Po Lu > Cc: Eli Zaretskii , 59351@debbugs.gnu.org > Date: Tue, 29 Nov 2022 08:47:23 +0800 > > Manuel Giraud writes: > > > Hi, > > > > Here is a new version of this patch that tries to adapt the menu bar > > height in the non-toolkit build. > > > > FWIW, I've also attached a quick video of how it works with the fvwm > > window manager with an emacs evaluating the following code: > > > > (split-window-right) > > (info-emacs-manual) > > (dolist (font '("Iosevka-18" "Ttyp0-12" "Inconsolata-14" "Inconsolata-32" > > "Noto Sans-6")) > > (sit-for 2) > > (set-face-font 'menu font)) > > > > It also works as intended with EXWM. > > If it works for you, please install this on the `master' branch (NOT > emacs-29!) Why not emacs-29? This fixes a bug, albeit an old one, and the conditions are (or supposed to be) such that the new code only affects X builds with no toolkits. So what is the danger you see in installing this on emacs-29?