From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59963: 29.0.50; 'window-max-chars-per-line' doesn't always work on GUI without fringe Date: Sun, 11 Dec 2022 18:14:28 +0200 Message-ID: <83ilihudcr.fsf@gnu.org> References: <87edt6dwgq.fsf@disroot.org> <83sfhmt30p.fsf@gnu.org> <87o7sac78t.fsf@disroot.org> <87h6y2c6fq.fsf@disroot.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12415"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59963@debbugs.gnu.org To: Akib Azmain Turja , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 11 17:15:35 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4OzH-000344-Ak for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 11 Dec 2022 17:15:35 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4Oyo-0004Ip-4Q; Sun, 11 Dec 2022 11:15:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4Oyl-0004ID-3f for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 11:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4Oyk-00010g-Og for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 11:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4Oyk-000666-ES for bug-gnu-emacs@gnu.org; Sun, 11 Dec 2022 11:15:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Dec 2022 16:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59963 X-GNU-PR-Package: emacs Original-Received: via spool by 59963-submit@debbugs.gnu.org id=B59963.167077527823410 (code B ref 59963); Sun, 11 Dec 2022 16:15:02 +0000 Original-Received: (at 59963) by debbugs.gnu.org; 11 Dec 2022 16:14:38 +0000 Original-Received: from localhost ([127.0.0.1]:46836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4OyL-00065W-Kc for submit@debbugs.gnu.org; Sun, 11 Dec 2022 11:14:37 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4OyK-00065L-M0 for 59963@debbugs.gnu.org; Sun, 11 Dec 2022 11:14:37 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4OyE-0000yj-UX; Sun, 11 Dec 2022 11:14:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1Msff46SQBXwJDJh41GYXw1+OU65RoQ68vdHTN2xZnQ=; b=fglHqzOZulUT q0hysXknNIQUsQ1H2kXMxOW8Tq/o5CMw4i1Y72srgsw6csGJdjKKR5Z89t7cWQVDMPxFJkAH6ruhx KEjZVhNS+hiRRfl/iMroVx9pHXS8IQfzwVFzxKTZr9F/v/rQxJCQ1MRHQSOzmGzVFTjFW+dpbxzar rrYyHBZkfuQHXf7CX5Di9wgQpi6HVBKIdfrBKDW7JuBgQJfL8WfQqktJ/6Spq0HxelLDmXw3xa71A bQIGwzWZgjbXkuaKVurovJTYLb3+wt7jXvcWCOMY3kOGza/1COfcVPMf5L1/UKEbPnY5b97l13l0H 9w5GGt4+iK9Lw/wtrW9SIw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4OyD-0005R8-RY; Sun, 11 Dec 2022 11:14:30 -0500 In-Reply-To: <87h6y2c6fq.fsf@disroot.org> (message from Akib Azmain Turja on Sun, 11 Dec 2022 21:21:13 +0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250622 Archived-At: > From: Akib Azmain Turja > Cc: 59963@debbugs.gnu.org > Date: Sun, 11 Dec 2022 21:21:13 +0600 > > I just found the root cause. I've used '(set-window-fringes nil 0 0)' > (from Doom as said by the original reporter) to hide fringe. It doesn't > set 'left-fringe-width' and 'right-fringe-width', which are checked by > 'window-max-chars-per-line'. Setting these two variables to zero fixes > the bug. It is wrong to use left-fringe-width and right-fringe-width here, because those are per _buffer_ not per _window_. set-window-fringes doesn't set them for this very reason, and it shouldn't. > Now I think this is a bug of _both_ Emacs and Doom. Doom doesn't set > the variables, hence this bug report here; and Emacs doesn't check > 'window-fringes'. > > What do you think? Using left/right-fringe-width in window-max-chars-per-line is IMO wrong, we should use window-fringes (which will return correct values both when the window has its private valuesm, either via set-window-fringes or via assignment of left/right-fringe-width, and when it doesn't). Martin, any comments?