From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59963: 29.0.50; 'window-max-chars-per-line' doesn't always work on GUI without fringe Date: Mon, 12 Dec 2022 15:10:16 +0200 Message-ID: <83iligsr7r.fsf@gnu.org> References: <87edt6dwgq.fsf@disroot.org> <83sfhmt30p.fsf@gnu.org> <87o7sac78t.fsf@disroot.org> <87h6y2c6fq.fsf@disroot.org> <83ilihudcr.fsf@gnu.org> <58cc3d32-65f9-d4ad-4668-732af0f3aa36@gmx.at> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9358"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59963@debbugs.gnu.org, akib@disroot.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 14:16:59 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4ifz-0002DH-J4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 14:16:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4iaH-00021E-9b; Mon, 12 Dec 2022 08:11:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4iaF-0001z3-3Y for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 08:11:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4iaE-0004PD-QR for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 08:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4iaE-0006dJ-2I for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 08:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59963 X-GNU-PR-Package: emacs Original-Received: via spool by 59963-submit@debbugs.gnu.org id=B59963.167085062325477 (code B ref 59963); Mon, 12 Dec 2022 13:11:02 +0000 Original-Received: (at 59963) by debbugs.gnu.org; 12 Dec 2022 13:10:23 +0000 Original-Received: from localhost ([127.0.0.1]:52862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4iZa-0006cr-Kl for submit@debbugs.gnu.org; Mon, 12 Dec 2022 08:10:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4iZZ-0006cj-Hx for 59963@debbugs.gnu.org; Mon, 12 Dec 2022 08:10:22 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4iZT-00047T-8l; Mon, 12 Dec 2022 08:10:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=duXF8AbeExbOCJNh+wqVpEiLGtN7nXj3+21jAyxqvP8=; b=hUltzdbfYL3M NUvjZGpIIHuij3C2sQxKkyzvE53FJY+t2XqI3vMYGcRExIoxqt2CxM2PaVafyHt6OXfnFnsRH3Xrn KmPhk0IvWlz1lr/frgkWWwYg0MZ2yrM6T4ynFlRVX5ZwbDD896vezebL6s4Q/sABPU5ZbLzG5TP4V V7a4xoXF2lZGJ0TyGTKpgLZGbomlhG6vYcLe9edEVSmZ40n3aw/GHFJS0+yDclB/YljSb2Gewyl3F lyaVtDLUrfiRd9lr0CdLh/Qq/C8Ybu8NEMinCgHVeE0HGoALRUwwWOpvgzYQZns1Xl3fG3l6VnES1 FM3Jo3jiDUX4/7/S9jkVoA==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4iZR-0000lF-Mr; Mon, 12 Dec 2022 08:10:14 -0500 In-Reply-To: <58cc3d32-65f9-d4ad-4668-732af0f3aa36@gmx.at> (message from martin rudalics on Mon, 12 Dec 2022 09:18:28 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250703 Archived-At: > Date: Mon, 12 Dec 2022 09:18:28 +0100 > Cc: 59963@debbugs.gnu.org > From: martin rudalics > > > Using left/right-fringe-width in window-max-chars-per-line is IMO > > wrong, we should use window-fringes (which will return correct values > > both when the window has its private valuesm, either via > > set-window-fringes or via assignment of left/right-fringe-width, and > > when it doesn't). > > This should have been done at the time that function was installed. Yes, I wonder what I was smoking back them. > If you do it now, you may break valid code like > > (let (max-chars) > (setq right-fringe-width 0) > (setq max-chars (window-max-chars-per-line)) > (set-window-buffer nil (window-buffer)) > max-chars) > > which currently yields 79 and would yield 80 with your proposal. Do we have such code somewhere? The correct way of doing that is to swap the lines that call window-max-chars-per-line and set-window-buffer, because AFAIU the latter will cause window-margins to return the values consistent with right-fringe-width just set.