From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Date: Sat, 17 Dec 2022 09:52:49 +0200 Message-ID: <83iliaii0e.fsf@gnu.org> References: <87len70wp1.fsf@posteo.net> <07bcf6a532b951e467af@heytings.org> <87h6xu29ze.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32923"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, 60130@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 17 08:53:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p6S0W-0008OZ-AN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 17 Dec 2022 08:53:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p6S0G-0001ji-Su; Sat, 17 Dec 2022 02:53:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6S0F-0001i1-Lb for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 02:53:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p6S0E-0003LH-Ol for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 02:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p6S0E-0004DP-0E for bug-gnu-emacs@gnu.org; Sat, 17 Dec 2022 02:53:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Dec 2022 07:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60130 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60130-submit@debbugs.gnu.org id=B60130.167126357216196 (code B ref 60130); Sat, 17 Dec 2022 07:53:01 +0000 Original-Received: (at 60130) by debbugs.gnu.org; 17 Dec 2022 07:52:52 +0000 Original-Received: from localhost ([127.0.0.1]:54447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6S04-0004DA-EE for submit@debbugs.gnu.org; Sat, 17 Dec 2022 02:52:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:42020) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p6S02-0004D4-Af for 60130@debbugs.gnu.org; Sat, 17 Dec 2022 02:52:51 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Rzw-0003DP-NV; Sat, 17 Dec 2022 02:52:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h8VLciDU51aCUowTx/+5dD3Z0S9tD0Qpx9gyen8h5eE=; b=IDUecvky6B/U r7EQSSq5FcIsYgCr5hsZWvLS+rrXe/RwYRKcupF2BV0tvoRF9efGdK5XYkMvhfxBc5I+G7wZAop+M tyx1NDO3CJNPomiDCVX1OZ72S+8jtb6VKzJkjt6f01XOr8iHk8JnSVHgukQ89/PV5W8dw3KfWLB8m NBDSUeAruHmDXy6Qk5aYSMLIJZe26edtLXealUiEKGjbkyiS8hrOeilouItg08d+b0h+mrJ9ub1J2 HmjtnHp4pT34p8Gh+Qzz6JNtQUcqTkXuJRfLkmOLMh3OeEpcIG3ywZM3LvZVlMejfzznfG+XgZThd O9r083Ox13PJjUlYvvgosQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p6Rzw-0005XN-75; Sat, 17 Dec 2022 02:52:44 -0500 In-Reply-To: <87h6xu29ze.fsf@posteo.net> (message from Philip Kaludercic on Fri, 16 Dec 2022 23:40:37 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251261 Archived-At: > Cc: 60130@debbugs.gnu.org > From: Philip Kaludercic > Date: Fri, 16 Dec 2022 23:40:37 +0000 > > Gregory Heytings writes: > > >> > >> I am not sure if I am missing something, but shouldn't the above > >> patch be "simpler" and more idiomatic? > >> > > > > Indeed. The "progn" is a remnant of an earlier version of that code, > > and can safely be removed. > > Ok, I'll push the change. Please don't install code cleanups on the release branch. I've reverted the commit on the release branch. Please install this on master instead. Thanks.