unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Philip Kaludercic <philipk@posteo.net>
Cc: gregory@heytings.org, 60130@debbugs.gnu.org
Subject: bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify
Date: Sat, 17 Dec 2022 09:52:49 +0200	[thread overview]
Message-ID: <83iliaii0e.fsf@gnu.org> (raw)
In-Reply-To: <87h6xu29ze.fsf@posteo.net> (message from Philip Kaludercic on Fri, 16 Dec 2022 23:40:37 +0000)

> Cc: 60130@debbugs.gnu.org
> From: Philip Kaludercic <philipk@posteo.net>
> Date: Fri, 16 Dec 2022 23:40:37 +0000
> 
> Gregory Heytings <gregory@heytings.org> writes:
> 
> >>
> >> I am not sure if I am missing something, but shouldn't the above
> >> patch be "simpler" and more idiomatic?
> >>
> >
> > Indeed.  The "progn" is a remnant of an earlier version of that code,
> > and can safely be removed.
> 
> Ok, I'll push the change.

Please don't install code cleanups on the release branch.

I've reverted the commit on the release branch.  Please install this
on master instead.

Thanks.





  reply	other threads:[~2022-12-17  7:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-16 23:12 bug#60130: [PATCH] ; * lisp/subr.el (internal--with-narrowing): Simplify Philip Kaludercic
2022-12-16 23:31 ` Gregory Heytings
2022-12-16 23:40   ` Philip Kaludercic
2022-12-17  7:52     ` Eli Zaretskii [this message]
2022-12-17 11:19       ` Philip Kaludercic
2022-12-17 11:31         ` Eli Zaretskii
2022-12-17 11:50           ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83iliaii0e.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=60130@debbugs.gnu.org \
    --cc=gregory@heytings.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).