* bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
@ 2023-01-17 13:44 Mickey Petersen
2023-01-19 22:30 ` Yuan Fu
0 siblings, 1 reply; 6+ messages in thread
From: Mickey Petersen @ 2023-01-17 13:44 UTC (permalink / raw)
To: 60880
A medley of issues here:
1. Executing `treesit-explore-mode' on a buffer with no valid grammar
support causes the minor mode (and playground buffer) to stick around and "load" anyway.
2. Bailing out of the grammar prompt does not, in actual fact, stop explore mode from proceeding. Instead it creates an empty buffer and it still engages the minor mode.
3. Killing the playground buffer does not remove the explore mode buffer.
4. treesit-explore-mode is stored against a buffer during `desktop-save' (and subsequently read with) `desktop-read'. Thus broken buffers or files inherit the explore mode. This is especially pernicious due to #1, #2, and #3.
In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.20, cairo version 1.16.0) of 2023-01-17 built on mickey-work
Repository revision: bb383a54910c3094e5d228e0af62bf70e36203ca
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12013000
System Description: Ubuntu 20.04.3 LTS
Configured using:
'configure --with-native-compilation --with-json --with-mailutils
--without-compress-install --with-imagemagick CC=gcc-10'
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
2023-01-17 13:44 bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly Mickey Petersen
@ 2023-01-19 22:30 ` Yuan Fu
2023-01-20 7:02 ` Eli Zaretskii
0 siblings, 1 reply; 6+ messages in thread
From: Yuan Fu @ 2023-01-19 22:30 UTC (permalink / raw)
To: Mickey Petersen; +Cc: 60880
Mickey Petersen <mickey@masteringemacs.org> writes:
> A medley of issues here:
>
> 1. Executing `treesit-explore-mode' on a buffer with no valid grammar
> support causes the minor mode (and playground buffer) to stick around and "load" anyway.
>
> 2. Bailing out of the grammar prompt does not, in actual fact, stop
> explore mode from proceeding. Instead it creates an empty buffer and
> it still engages the minor mode.
>
> 3. Killing the playground buffer does not remove the explore mode buffer.
>
> 4. treesit-explore-mode is stored against a buffer during
> `desktop-save' (and subsequently read with) `desktop-read'. Thus
> broken buffers or files inherit the explore mode. This is especially
> pernicious due to #1, #2, and #3.
Ok, I fixed those problems. Now if the language is not available,
treesit-explore-mode raises an error instead of continuing, desktop-save
will not save the explorer buffer, and killing the source buffer also
kills the explorer buffer.
Invalid language doesn’t stop treesit-explore-mode from turning on, even
if it doesn’t create buffers, etc, since I think this is how minor modes
usually behave.
Yuan
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
2023-01-19 22:30 ` Yuan Fu
@ 2023-01-20 7:02 ` Eli Zaretskii
2023-01-20 7:59 ` Juri Linkov
2023-01-20 9:08 ` Mickey Petersen
0 siblings, 2 replies; 6+ messages in thread
From: Eli Zaretskii @ 2023-01-20 7:02 UTC (permalink / raw)
To: Yuan Fu; +Cc: 60880, mickey
> Cc: 60880@debbugs.gnu.org
> From: Yuan Fu <casouri@gmail.com>
> Date: Thu, 19 Jan 2023 14:30:46 -0800
>
>
> Mickey Petersen <mickey@masteringemacs.org> writes:
>
> > A medley of issues here:
> >
> > 1. Executing `treesit-explore-mode' on a buffer with no valid grammar
> > support causes the minor mode (and playground buffer) to stick around and "load" anyway.
> >
> > 2. Bailing out of the grammar prompt does not, in actual fact, stop
> > explore mode from proceeding. Instead it creates an empty buffer and
> > it still engages the minor mode.
> >
> > 3. Killing the playground buffer does not remove the explore mode buffer.
> >
> > 4. treesit-explore-mode is stored against a buffer during
> > `desktop-save' (and subsequently read with) `desktop-read'. Thus
> > broken buffers or files inherit the explore mode. This is especially
> > pernicious due to #1, #2, and #3.
>
> Ok, I fixed those problems. Now if the language is not available,
> treesit-explore-mode raises an error instead of continuing, desktop-save
> will not save the explorer buffer, and killing the source buffer also
> kills the explorer buffer.
I don't think the desktop-save part is correct: the test should be at
desktop-read time, not at desktop-save time. Because the fact we had
the language available when we saved the desktop doesn't guarantee we
will have it available when restoring that desktop: it could be in a
different build of Emacs or even on a different machine.
I'm not sure I understand the problem which desktop-read has when
restoring desktop with buffers in treesit-explore-mode, but if the
problems are more than just warning messages, then desktop-read should
detect these problems, emit an echo-area message, and refrain from
restoring the mode. Like it does with buffers that visited files
which are no longer there, for example.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
2023-01-20 7:02 ` Eli Zaretskii
@ 2023-01-20 7:59 ` Juri Linkov
2023-01-20 13:13 ` Eli Zaretskii
2023-01-20 9:08 ` Mickey Petersen
1 sibling, 1 reply; 6+ messages in thread
From: Juri Linkov @ 2023-01-20 7:59 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 60880, Yuan Fu, mickey
> I don't think the desktop-save part is correct: the test should be at
> desktop-read time, not at desktop-save time. Because the fact we had
> the language available when we saved the desktop doesn't guarantee we
> will have it available when restoring that desktop: it could be in a
> different build of Emacs or even on a different machine.
When the buffer is not saved, then it will cause no problems when restoring.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
2023-01-20 7:02 ` Eli Zaretskii
2023-01-20 7:59 ` Juri Linkov
@ 2023-01-20 9:08 ` Mickey Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Mickey Petersen @ 2023-01-20 9:08 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 60880, Yuan Fu
Eli Zaretskii <eliz@gnu.org> writes:
>> Cc: 60880@debbugs.gnu.org
>> From: Yuan Fu <casouri@gmail.com>
>> Date: Thu, 19 Jan 2023 14:30:46 -0800
>>
>>
>> Mickey Petersen <mickey@masteringemacs.org> writes:
>>
>> > A medley of issues here:
>> >
>> > 1. Executing `treesit-explore-mode' on a buffer with no valid grammar
>> > support causes the minor mode (and playground buffer) to stick around and "load" anyway.
>> >
>> > 2. Bailing out of the grammar prompt does not, in actual fact, stop
>> > explore mode from proceeding. Instead it creates an empty buffer and
>> > it still engages the minor mode.
>> >
>> > 3. Killing the playground buffer does not remove the explore mode buffer.
>> >
>> > 4. treesit-explore-mode is stored against a buffer during
>> > `desktop-save' (and subsequently read with) `desktop-read'. Thus
>> > broken buffers or files inherit the explore mode. This is especially
>> > pernicious due to #1, #2, and #3.
>>
>> Ok, I fixed those problems. Now if the language is not available,
>> treesit-explore-mode raises an error instead of continuing, desktop-save
>> will not save the explorer buffer, and killing the source buffer also
>> kills the explorer buffer.
>
> I don't think the desktop-save part is correct: the test should be at
> desktop-read time, not at desktop-save time. Because the fact we had
> the language available when we saved the desktop doesn't guarantee we
> will have it available when restoring that desktop: it could be in a
> different build of Emacs or even on a different machine.
>
> I'm not sure I understand the problem which desktop-read has when
> restoring desktop with buffers in treesit-explore-mode, but if the
> problems are more than just warning messages, then desktop-read should
> detect these problems, emit an echo-area message, and refrain from
> restoring the mode. Like it does with buffers that visited files
> which are no longer there, for example.
Another problem is that it stops the loading process, pending manual
selection of the grammar you want explore mode to use. It would be
nice if we saved the previous choice -- when you made the choice to
begin with -- so that, upon read, it does not have to ask.
That way the desktop read experience is not interrupted by prompts
during Emacs startup.
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly
2023-01-20 7:59 ` Juri Linkov
@ 2023-01-20 13:13 ` Eli Zaretskii
0 siblings, 0 replies; 6+ messages in thread
From: Eli Zaretskii @ 2023-01-20 13:13 UTC (permalink / raw)
To: Juri Linkov; +Cc: 60880, casouri, mickey
> From: Juri Linkov <juri@linkov.net>
> Cc: Yuan Fu <casouri@gmail.com>, 60880@debbugs.gnu.org,
> mickey@masteringemacs.org
> Date: Fri, 20 Jan 2023 09:59:09 +0200
>
> > I don't think the desktop-save part is correct: the test should be at
> > desktop-read time, not at desktop-save time. Because the fact we had
> > the language available when we saved the desktop doesn't guarantee we
> > will have it available when restoring that desktop: it could be in a
> > different build of Emacs or even on a different machine.
>
> When the buffer is not saved, then it will cause no problems when restoring.
But users can expect the buffer to be saved and restored, when that
presents no problems. We cannot unilaterally decide they cannot
expect such buffers with their modes being restored.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-01-20 13:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-17 13:44 bug#60880: 30.0.50; tree-sitter `treesit-explore-mode' is buggy and does not behave properly Mickey Petersen
2023-01-19 22:30 ` Yuan Fu
2023-01-20 7:02 ` Eli Zaretskii
2023-01-20 7:59 ` Juri Linkov
2023-01-20 13:13 ` Eli Zaretskii
2023-01-20 9:08 ` Mickey Petersen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).