From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>
Cc: 61235@debbugs.gnu.org, mickey@masteringemacs.org
Subject: bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser
Date: Tue, 07 Feb 2023 05:31:11 +0200 [thread overview]
Message-ID: <83ilgep2ww.fsf@gnu.org> (raw)
In-Reply-To: <E600D10A-3D79-4F7B-8F80-1C8DE064CC25@gmail.com> (message from Yuan Fu on Mon, 6 Feb 2023 19:00:30 -0800)
> From: Yuan Fu <casouri@gmail.com>
> Date: Mon, 6 Feb 2023 19:00:30 -0800
> Cc: Mickey Petersen <mickey@masteringemacs.org>,
> 61235@debbugs.gnu.org
>
> > Yuan, any reason not to extend treesit-node-check instead?
>
> I did extend treesit-node-check in the patch. But I also added a function treesit-parser-live-p, which makes the same check but directly on a parser. It just made sense to me that if we let treesit-node-check check the nodes’ parser’s status, we’d also add a function to allow directly checking the status of a parser.
That additional function would signal an error in the case discussed
here, so I'm not sure we should add it in that shape, or at all. Why
isn't treesit-node-check enough?
next prev parent reply other threads:[~2023-02-07 3:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 19:46 bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser Mickey Petersen
2023-02-06 4:24 ` Yuan Fu
2023-02-06 12:34 ` Eli Zaretskii
2023-02-06 12:35 ` Mickey Petersen
2023-02-06 13:19 ` Eli Zaretskii
2023-02-06 13:19 ` Mickey Petersen
2023-02-06 14:05 ` Eli Zaretskii
2023-02-06 14:08 ` Mickey Petersen
2023-02-06 15:21 ` Eli Zaretskii
2023-02-07 3:00 ` Yuan Fu
2023-02-07 3:31 ` Eli Zaretskii [this message]
2023-02-07 4:55 ` Yuan Fu
2023-02-07 12:24 ` Eli Zaretskii
2023-02-08 3:54 ` Yuan Fu
2023-02-07 8:03 ` Mickey Petersen
2023-02-08 3:52 ` Yuan Fu
2023-02-08 8:41 ` Mickey Petersen
2023-02-10 1:28 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ilgep2ww.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61235@debbugs.gnu.org \
--cc=casouri@gmail.com \
--cc=mickey@masteringemacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).