From: Eli Zaretskii <eliz@gnu.org>
To: Theodor Thornhill <theo@thornhill.no>
Cc: 61558@debbugs.gnu.org
Subject: bug#61558: 29.0.60; Indentation with c-ts-mode doesn't work in code guarded by #ifdef..#endif
Date: Sat, 18 Feb 2023 11:53:49 +0200 [thread overview]
Message-ID: <83ilfzz4cy.fsf@gnu.org> (raw)
In-Reply-To: <877cwgoyws.fsf@thornhill.no> (message from Theodor Thornhill on Fri, 17 Feb 2023 20:49:23 +0100)
> From: Theodor Thornhill <theo@thornhill.no>
> Cc: 61558@debbugs.gnu.org
> Date: Fri, 17 Feb 2023 20:49:23 +0100
>
> Can you test this patch? It seems to work for me, but I'm no C expert.
Thanks, this is much better. However, the handling of #if (as opposed
to #ifdef) is still incorrect. For example, go to the end of line
3376 of dispnew.c and type RET: point goes to column zero, not column
2. If you convert "#if" to #ifdef", the behavior becomes correct.
Same problem exists with #elif.
Doesn't tree-sitter grammar consider #if and #elif preprocessor nodes?
Also, there's a problem with #define in the middle of code. For
example, here:
/* Put a `display' property on the string for the captions to display,
put a `menu_item' property on tab-bar items with a value that
is the index of the item in F's tab-bar item vector. */
for (i = 0; i < f->n_tab_bar_items; ++i)
{
#define PROP(IDX) \
AREF (f->tab_bar_items, i * TAB_BAR_ITEM_NSLOTS + (IDX))
caption = Fcopy_sequence (PROP (TAB_BAR_ITEM_CAPTION)); <<<<<<<<<<
/* Put a `display' text property on the string for the caption to
display. Put a `menu-item' property on the string that gives
the start of this item's properties in the tab-bar items
vector. */
AUTO_LIST2 (props, Qmenu_item, make_fixnum (i * TAB_BAR_ITEM_NSLOTS));
Fadd_text_properties (make_fixnum (0), make_fixnum (SCHARS (caption)),
props, caption);
f->desired_tab_bar_string =
concat2 (f->desired_tab_bar_string, caption);
#undef PROP <<<<<<<<<<<<<<<<<<<<
}
Typing RET at the end of the two marked lines goes to column zero
instead of the expected non-zero column. So it sounds like #define
and #undef are also not handled correctly yet.
next prev parent reply other threads:[~2023-02-18 9:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 20:48 bug#61558: 29.0.60; Indentation with c-ts-mode doesn't work in code guarded by #ifdef..#endif Eli Zaretskii
2023-02-17 19:23 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-17 19:32 ` Eli Zaretskii
2023-02-17 19:49 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-18 9:53 ` Eli Zaretskii [this message]
2023-02-18 21:11 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-18 21:30 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 7:42 ` Eli Zaretskii
2023-02-19 9:20 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 7:43 ` Eli Zaretskii
2023-02-19 8:01 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-25 4:30 ` Yuan Fu
2023-02-25 6:37 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-26 8:49 ` Yuan Fu
2023-02-26 10:30 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ilfzz4cy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=61558@debbugs.gnu.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).