From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63470: [PATCH] Use faster option for running vc-hg status Date: Wed, 17 May 2023 14:55:57 +0300 Message-ID: <83ilcrxjci.fsf@gnu.org> References: <83h6shbaiv.fsf@gnu.org> <83bkiobwsu.fsf@gnu.org> <83o7mjxk3i.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33671"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 63470@debbugs.gnu.org To: Spencer Baugh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 17 13:56:37 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pzFll-0008Z5-10 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 May 2023 13:56:37 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pzFlL-0002vW-H7; Wed, 17 May 2023 07:56:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzFlD-0002uu-9V for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 07:56:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pzFlC-00014D-R9 for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 07:56:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pzFlC-0003rU-He for bug-gnu-emacs@gnu.org; Wed, 17 May 2023 07:56:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 11:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63470-submit@debbugs.gnu.org id=B63470.168432455514797 (code B ref 63470); Wed, 17 May 2023 11:56:02 +0000 Original-Received: (at 63470) by debbugs.gnu.org; 17 May 2023 11:55:55 +0000 Original-Received: from localhost ([127.0.0.1]:49182 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzFl5-0003qZ-GZ for submit@debbugs.gnu.org; Wed, 17 May 2023 07:55:55 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39688) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzFl3-0003pp-Ig for 63470@debbugs.gnu.org; Wed, 17 May 2023 07:55:54 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzFky-000131-1X; Wed, 17 May 2023 07:55:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DaZ9OX0XhwujPJSn00tS81nf5fv8TujQYPbPk3Nn+0U=; b=ro6C2LCyaC0p xnNrU6nBeQIKqMH2c9xHDThF29S+uaqHDap8u1jGmyLHhwvtMqWamJyVh8pVDCMJdMiKDlWaJpeJW e8dHS7lnTFKuH+7k2CEWjnEYCrPqeqpAEAuAYZPjg439V7fx75GNVOCV52E9t3gG/v4New89fVQ9e TO34czOhxIzYMLGLVOlDMYtR3ra/uFjpzaVwMtQrTX98wLR3Zcv/wzpTvrFbbOQhPw9M2D9Kpf3UZ T/EzBsWC/CdcaJKa+HEqoML85gmfvC6WH3hmgPr/zV+hQ/L3rTyA6lo50nLEbhOUGImVPDmBZ7eqF eIqQvX51nAyJYcmVt/YQ4g==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzFkx-0004ov-GW; Wed, 17 May 2023 07:55:47 -0400 In-Reply-To: (message from Spencer Baugh on Wed, 17 May 2023 07:47:09 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261843 Archived-At: > From: Spencer Baugh > Date: Wed, 17 May 2023 07:47:09 -0400 > Cc: Dmitry Gutov , 63470@debbugs.gnu.org > > Thanks, but I'd prefer to call the new function only once, and record > the result in some variable. We do such things in umpteen other > places, so it looks strange to test the version each time only in this > case. > > Isn't that what I'm doing? I record the version in a variable and only compute it once. Sorry, you are right. I claim temporary blindness.