From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 26 May 2023 11:46:05 +0300 Message-ID: <83ilcflbua.fsf@gnu.org> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87v8gfmqyt.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24710"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 26 10:46:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2T5a-0006C4-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 May 2023 10:46:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2T5L-00041u-Ah; Fri, 26 May 2023 04:46:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2T5G-00041Y-Rb for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 04:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2T5G-0004O1-H8 for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 04:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2T5F-0002Um-RY for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 04:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 May 2023 08:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.16850907439559 (code B ref 63731); Fri, 26 May 2023 08:46:01 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 26 May 2023 08:45:43 +0000 Original-Received: from localhost ([127.0.0.1]:48786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2T4x-0002U7-DG for submit@debbugs.gnu.org; Fri, 26 May 2023 04:45:43 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:44366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2T4v-0002Tq-47 for 63731@debbugs.gnu.org; Fri, 26 May 2023 04:45:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2T4p-0004K2-MF; Fri, 26 May 2023 04:45:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=MWt7ndGCnrRW5HUbE2U/rHxxf7gbYTRMM747/WEDmPI=; b=nHHQ48eHWCB4Q1AczJC8 gZEDClO+gBt2LY2+cnGK+0UhgbXpDKpZvHwUpTSxM6BXSlUGUyAQHDiGqxk6OuhEX3QD1A0p3l0gc 3gT1ky7tW1zMT4hqb+mZG5xkx+gbhbRSssPYr4YhDOFbN4XaNrh5NRwyfEl9hUXKb9JGyhWLsQRtN yQgTrWdFimrkP26/XlTdNfa4HyL4/ao4VafWh5TMtIhNItJ7gNTWlIv4Egdeq8R3TSLzfNw6aAQLh Dp9PK2UmbJHuDy/NH3PNpmZwwfqOkt4WevMxAhiHBctUyD/2gvyCVxP2sS8tq9pag/Dzl5Tmnkgyz mTFboMThUARDaw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2T4p-00075m-5o; Fri, 26 May 2023 04:45:35 -0400 In-Reply-To: <87v8gfmqyt.fsf@gmail.com> (message from Robert Pluim on Fri, 26 May 2023 10:34:02 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262414 Archived-At: > From: Robert Pluim > Cc: Steven Allen , 63731@debbugs.gnu.org > Date: Fri, 26 May 2023 10:34:02 +0200 > > Ugh. The following fixes it for me: > > diff --git a/lisp/composite.el b/lisp/composite.el > index fb8b76114f4..af86d1436d3 100644 > --- a/lisp/composite.el > +++ b/lisp/composite.el > @@ -756,7 +756,7 @@ compose-gstring-for-dotted-circle > ;; Allow for bootstrapping without uni-*.el. > (when unicode-category-table > (let ((elt `([,(purecopy "\\c.\\c^+") 1 compose-gstring-for-graphic] > - [nil 0 compose-gstring-for-graphic]))) > + ))) This is unacceptable, AFAIU. We cannot unsupported (or change) the correct display of mark characters, can we? > Although the following is less invasive: > > diff --git a/lisp/composite.el b/lisp/composite.el > index fb8b76114f4..333428f008a 100644 > --- a/lisp/composite.el > +++ b/lisp/composite.el > @@ -762,6 +762,11 @@ compose-gstring-for-dotted-circle > (if (memq val '(Mn Mc Me)) > (set-char-table-range composition-function-table key elt))) > unicode-category-table)) > + ;; for Emoji presentation selector > + (set-char-table-range > + composition-function-table > + #xFE0F > + `([,(purecopy "\\c.\ufe0f") 1 compose-gstring-for-graphic])) > ;; for dotted-circle > (aset composition-function-table #x25CC > `([,(purecopy ".\\c^") 0 compose-gstring-for-dotted-circle])) Can you please explain why the current setup doesn't work in this case, even though "C-u C-x =" says the composition was done? And how the above patch fixes that? > Didnʼt we conclude that composition had some issues with multiple > entries for the same codepoint if there was a mix for forward and > backward looking regexp? Not sure I understand to what does this allude. What mix of forward and backward looking regexp do you see?