unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 64104@debbugs.gnu.org, andreas.roehler@easy-emacs.de
Subject: bug#64104: Subject: 30.0.50; uncomment-region-default-1
Date: Sun, 18 Jun 2023 08:53:03 +0300	[thread overview]
Message-ID: <83ilblpb9c.fsf@gnu.org> (raw)
In-Reply-To: <jwva5wyos6p.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sat, 17 Jun 2023 14:39:08 -0400)

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Andreas Röhler <andreas.roehler@easy-emacs.de>,
>   64104@debbugs.gnu.org
> Date: Sat, 17 Jun 2023 14:39:08 -0400
> 
> >> C-u comment-dwim RET with an active region of the following Python code:
> >> 
> >> ---
> >> # for i in text:
> >> #     print("(i): {}".format(str(i)))
> >> ---
> >> 
> >> results in error saying
> >> 
> >> uncomment-region-default-1: Beginning of buffer
> 
> > Stefan, any comments?
> 
> - The error we give is not very user-friendly, so it might be good to
>   catch it and re-raise it as something more meaning ful the specific
>   operation performed.
> 
> - I have the vague impression that in some earlier version of that code we
>   would not signal an error but just remove as many comment markers as
>   possible (but no more than requested).
>   That could be a more friendly behavior.

I'll leave the bug open, then.  Patches to improve this command are
welcome.





  reply	other threads:[~2023-06-18  5:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  8:51 bug#64104: Subject: 30.0.50; uncomment-region-default-1 Andreas Röhler
2023-06-17  8:38 ` Eli Zaretskii
2023-06-17 18:39   ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-06-18  5:53     ` Eli Zaretskii [this message]
2023-06-18 13:00       ` Andreas Röhler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ilblpb9c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=64104@debbugs.gnu.org \
    --cc=andreas.roehler@easy-emacs.de \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).