unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#64602: 28.2; [PATCH] Remove outdated FIXME
@ 2023-07-13 20:02 YE via Bug reports for GNU Emacs, the Swiss army knife of text editors
  2023-07-14  5:33 ` Eli Zaretskii
  0 siblings, 1 reply; 2+ messages in thread
From: YE via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2023-07-13 20:02 UTC (permalink / raw)
  To: 64602

[-- Attachment #1: Type: text/plain, Size: 128 bytes --]


This removes FIXME that suggests to use 'define-derived-mode'. The
latter has been in place for 2 years now (since b39b5647).


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Remove outdated FIXME --]
[-- Type: text/x-patch, Size: 839 bytes --]

From abc929437b8b96d3e8d8d1e7eba1bacefcd84e6e Mon Sep 17 00:00:00 2001
From: YugaEgo <yet@ego.team>
Date: Thu, 13 Jul 2023 22:50:27 +0300
Subject: [PATCH] ; * lisp/progmodes/sql.el (sql-interactive-mode): Remove
 FIXME

---
 lisp/progmodes/sql.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/sql.el b/lisp/progmodes/sql.el
index c6667c075f6..89d62ab3a61 100644
--- a/lisp/progmodes/sql.el
+++ b/lisp/progmodes/sql.el
@@ -4200,7 +4200,7 @@ must tell Emacs.  Here's how to do that in your init file:
 
 (put 'sql-interactive-mode 'mode-class 'special)
 (put 'sql-interactive-mode 'custom-mode-group 'SQL)
-;; FIXME: Why not use `define-derived-mode'?
+
 (define-derived-mode sql-interactive-mode comint-mode "SQLi[?]"
   "Major mode to use a SQL interpreter interactively.
 
-- 
2.39.2 (Apple Git-143)


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#64602: 28.2; [PATCH] Remove outdated FIXME
  2023-07-13 20:02 bug#64602: 28.2; [PATCH] Remove outdated FIXME YE via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2023-07-14  5:33 ` Eli Zaretskii
  0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2023-07-14  5:33 UTC (permalink / raw)
  To: YE; +Cc: 64602-done

> Date: Thu, 13 Jul 2023 23:02:52 +0300
> From:  YE via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> This removes FIXME that suggests to use 'define-derived-mode'. The
> latter has been in place for 2 years now (since b39b5647).

Thanks, installed on the emacs-29 branch, and closing the bug.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-14  5:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-13 20:02 bug#64602: 28.2; [PATCH] Remove outdated FIXME YE via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-07-14  5:33 ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).