From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Thu, 07 Sep 2023 13:19:48 +0300 Message-ID: <83il8mz3nf.fsf__6194.10324595577$1694082083$gmane$org@gnu.org> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <87ledju2j7.fsf@localhost> <837cp3333w.fsf@gnu.org> <87pm2upajy.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19382"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65734@debbugs.gnu.org, emacs-orgmode@gnu.org, iota@whxvd.name To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 12:21:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeC8R-0004qh-Cp for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 12:21:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeC8E-00012c-Ld; Thu, 07 Sep 2023 06:21:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeC8C-00011i-R4 for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 06:21:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeC8C-0008EM-Fe for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 06:21:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeC8D-0005I8-KS for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 06:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 10:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.169408202620290 (code B ref 65734); Thu, 07 Sep 2023 10:21:01 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 7 Sep 2023 10:20:26 +0000 Original-Received: from localhost ([127.0.0.1]:38681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeC7c-0005HA-93 for submit@debbugs.gnu.org; Thu, 07 Sep 2023 06:20:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeC7M-0005Gc-Ll for 65734@debbugs.gnu.org; Thu, 07 Sep 2023 06:20:23 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeC7E-0007vR-IH; Thu, 07 Sep 2023 06:20:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wk+dCVtdvorLfd5DfGTe+YAQBn567+qXNgnYuLvUg3Q=; b=lJNjmgthrITF tTFV9GiqAmt9LXnfyATnHpN0bxTVaIe/2iZ5p+RDKNZ8dQ5fZbRuSiSmRSTwxt4zQBqXb0JfV+zZd QINRUho3Tn7lwyvXrmwoRJyBpo4NvXSwUjhST2WFuM0s1SrW0fRmE5+rYukWhTvO4hV6POHq2al6Z RdCcZ2oPh1ZatuHXB/W5k0IZrQ4R8SHnhqNcO8cmtDPD1E6Kp2fJE5z6hGQQ79NnfVt+wfMCMEBoa CgJTtz5Cx+tNd+qe5ckFrDowTkzyZAwu8YtpLxuzGnho/N2aJo2LIH0GF+0lIPvtGSMFW8g3882Ej hjJvtzv0Zffp7xgKuOBMZw==; In-Reply-To: <87pm2upajy.fsf@localhost> (message from Ihor Radchenko on Thu, 07 Sep 2023 10:00:49 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269636 Archived-At: > From: Ihor Radchenko > Cc: iota@whxvd.name, 65734@debbugs.gnu.org, emacs-orgmode@gnu.org > Date: Thu, 07 Sep 2023 10:00:49 +0000 > > Eli Zaretskii writes: > > > Then perhaps just a special value for buffer-invisibility-spec, or > > some other simple variation of a property Org already uses? > > We may have a misunderstanding here. > In "* Heading text :tag1:tag2:", everything is visible yet Org needs to > protect ":tag1:tag2: from being killed by `kill-line', but not from > `kill-whole-line'. Moreover, the behaviour also depends on the point > position - if point is inside ":tag1:tag2:", we fall back to the default > behaviour. And the whole "special" behaviour can also be switched off by > flipping `org-special-ctrl-k'. > > Invisibility has nothing to do with this need. Isn't it true that invisibility is what causes the user expectations in this case to begin with? Then saying that "invisibility has nothing to do with this" is not really accurate, is it? > >> What about something like `end-of-visible-line-function'? > > > > That is also a possibility, but it will then affect kill-line > > _anywhere_ in the buffer, whereas a text property can have a more > > localized effect. Are you sure kill-line will need this customization > > on the whole buffer? > > Applying text property is not free - (1) we need to do it across the > whole buffer, which scales poorly; (2) we need to keep it updated as the > buffer changes, which scales even worse. In addition, adding more text > properties slow down redisplay, which Org already strains to its limits. I understand, but in my book correctness tramps performance, and I was trying to make the point that perhaps modifying the behavior of kill-line everywhere in Org buffers might be incorrect for some cases.