From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Date: Tue, 19 Dec 2023 14:41:10 +0200 Message-ID: <83il4uicux.fsf@gnu.org> References: <878r7s5cdf.fsf@honnef.co> <83fs1tbou1.fsf@gnu.org> <835y1zo3rw.fsf@gnu.org> <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> <50920549-006c-0153-2471-02e41a3dada7@gutov.dev> <8c7cd429-bdc3-4fac-ad1c-fbad793bf1a0@gmail.com> <231ebcd1-ec30-0432-82e7-d63e11cd65f7@gutov.dev> <765D713E-9923-4F66-9044-9D69C104C9B0@gmail.com> <33fe5d61-5022-67c5-6a65-babde4fb7f91@gutov.dev> <92CACD38-9534-4A07-8DE3-CE8408272FB6@gmail.com> <59CC46F7-867E-4C74-83EC-49B41DF0FAB8@gmail.com> <8fa0e506-6efc-57d4-6034-e938f97b1fb0@gutov.dev> <83plz3i9vv.fsf@gnu.org> <83o7emj2qd.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24015"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, casouri@gmail.com, 66732@debbugs.gnu.org, dominik@honnef.co To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 19 13:42:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFZQT-00063K-L3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Dec 2023 13:42:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFZQC-0005pN-VP; Tue, 19 Dec 2023 07:42:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFZQ7-0005mv-UJ for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 07:42:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFZQ7-0004dF-Ls for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 07:41:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFZQ9-0002rd-TF for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 07:42:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 12:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66732 X-GNU-PR-Package: emacs Original-Received: via spool by 66732-submit@debbugs.gnu.org id=B66732.170298971010987 (code B ref 66732); Tue, 19 Dec 2023 12:42:01 +0000 Original-Received: (at 66732) by debbugs.gnu.org; 19 Dec 2023 12:41:50 +0000 Original-Received: from localhost ([127.0.0.1]:34558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFZPu-0002r2-MS for submit@debbugs.gnu.org; Tue, 19 Dec 2023 07:41:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFZPs-0002qk-99 for 66732@debbugs.gnu.org; Tue, 19 Dec 2023 07:41:45 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFZPh-0004bT-0b; Tue, 19 Dec 2023 07:41:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=uGrdU/NrlXWRyYDI6h8rW6wQFx5P+MF5OVULxx/Mgns=; b=iRILgBGgfJop oGtj7p44m9s/On1z2Tw+jajy8KNedIUN2REMAt1tkFd4xx3NC1Ijam2EmLmTruvc0kh4A/VnikLk2 1bo/IWtkgpV4/14NykbpgAD74+/QoXVZENEWzATsHNnUHEGfgm668pgeMQAN5VRRDgt2eSFQpIwHg KxMZ6fbwdh+ElQux3OZjQbjsaiShsAeN8sfrdtLfYq1jvVKQrCmz9fODnx3JNcarI8aeprH/ofDn3 2u8ZbJ0H0sVCuFQRVwQt6KzufCfU7PFX35/eKOkbLLd7scpsdvbbTh/goAKhAZSh+zNnojKpqwszg 5rHJmZaIg+R8NOLBicLPfw==; In-Reply-To: (message from Stefan Monnier on Mon, 18 Dec 2023 22:40:59 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276507 Archived-At: > From: Stefan Monnier > Cc: Dmitry Gutov , 66732@debbugs.gnu.org, > dominik@honnef.co, casouri@gmail.com > Date: Mon, 18 Dec 2023 22:40:59 -0500 > > >> It seems like in our scenario the region does not get re-rendered even > >> when some of the faces changed in there. > > Can't happen. > > I think Dmitry is talking about the case where the faces were change > after the text was rendered (but before the end of the redisplay cycle). > > I.e. the redisplay starts, renders up to position POS, then calls > jit-lock because `fonfitied` is nil, and jit-lock modifies faces of text > *before* POS. This can only happen if a function called from jit-lock doesn't comply to the protocol wrt such changes, right? Because otherwise the modified region would have been re-rendered on the next redisplay cycle at the latest.