unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: rudalics@gmx.at
Cc: 12170@debbugs.gnu.org
Subject: bug#12170: save-excursion fails boundary case with recenter
Date: Sat, 11 Aug 2012 19:49:41 +0300	[thread overview]
Message-ID: <83has9cr16.fsf@gnu.org> (raw)
In-Reply-To: <83ipcpcruu.fsf@gnu.org>

> Date: Sat, 11 Aug 2012 19:31:53 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 12170@debbugs.gnu.org, wbrodie@panix.com
> 
> > Date: Sat, 11 Aug 2012 18:05:14 +0200
> > From: martin rudalics <rudalics@gmx.at>
> > CC: wbrodie@panix.com, 12170@debbugs.gnu.org
> > 
> > So the difference should be in one of the four assignments
> > 
> >    w->start_at_line_beg = 0;
> >    w->update_mode_line = 1;
> >    w->last_modified = 0;
> >    w->last_overlay_modified = 0;
> > 
> > and I'd obviously vote for the first one.  Interesting side-effect.
> 
> FWIW, there are only 2 places in redisplay that look at
> w->start_at_line_beg, but neither your nor Bill's recipe don't
> exercise the code of either of these two places.

As another FWIW, running the recipe with save-window-excursion shows
that set-window-configuration called after the body tries to set the
window start at position 1 and the window point at position 67.  But
the last position in a 33-line window that starts at position 1 is 33,
so these two values cannot be satisfied at once.





  reply	other threads:[~2012-08-11 16:49 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-10  1:23 bug#12170: save-excursion fails boundary case with recenter Bill Brodie
2012-08-10  9:34 ` martin rudalics
2012-08-10  9:50   ` Bastien
2012-08-10 13:03     ` martin rudalics
2012-08-10 13:40   ` Bill Brodie
2012-08-10 14:47     ` martin rudalics
2012-08-10 16:18       ` Stefan Monnier
2012-08-10 16:47         ` martin rudalics
2012-08-10 17:07           ` Stefan Monnier
2012-08-10 19:01       ` Eli Zaretskii
2012-08-11  9:32         ` martin rudalics
2012-08-11 11:11           ` Eli Zaretskii
2012-08-11 14:22             ` martin rudalics
2012-08-11 15:10               ` Eli Zaretskii
2012-08-11 16:05                 ` martin rudalics
2012-08-11 16:31                   ` Eli Zaretskii
2012-08-11 16:49                     ` Eli Zaretskii [this message]
2012-08-12 10:31                       ` martin rudalics
2012-08-11 16:27                 ` Bill Brodie
2012-08-10 15:04     ` Stefan Monnier
2012-08-10 15:46       ` Bill Brodie
2012-08-10 16:46         ` martin rudalics
2012-08-10 16:46       ` martin rudalics
2012-08-10 18:58     ` Eli Zaretskii
2012-08-11  9:31       ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83has9cr16.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=12170@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).