From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 15260@debbugs.gnu.org
Subject: bug#15260: cannot build in a directory with non-ascii characters
Date: Fri, 25 Oct 2013 17:25:05 +0300 [thread overview]
Message-ID: <83hac5h1ha.fsf@gnu.org> (raw)
In-Reply-To: <81ppqums9o.fsf@fencepost.gnu.org>
> From: Glenn Morris <rgm@gnu.org>
> Cc: 15260@debbugs.gnu.org
> Date: Thu, 24 Oct 2013 14:35:15 -0400
>
> Eli Zaretskii wrote:
>
> > case "$var" in
> > *[[^\ -~]]*) AC_MSG_ERROR([Emacs cannot be built or installed in a directory whose name contains non-ASCII characters: $var]) ;;
> > esac
> >
> > This is quite drastic.
>
> I don't think so. The alternative is a cryptic failure during the build stage.
>
> > Do we understand what is the underlying technical reason for the
> > build failures?
>
> Something to do with failure to find files, just as it was 6 years ago.
> http://lists.gnu.org/archive/html/emacs-devel/2007-05/msg00984.html
>
> The immediate problem for me is a dump failure:
>
> Finding pointers to doc strings...
> Finding pointers to doc strings...done
> Dumping under the name emacs
> emacs: Can't open /path/to/non-ascii/src/temacs for reading: No such file
> or directory
> make[1]: *** [bootstrap-emacs] Error 1
Does the change below help?
> Why not make a non-ASCII directory and try it yourself...
It requires too much setup on my part (this cannot be simulated on
Windows without too much hassle). But I will do that if there's no
easier way. I just thought that some analysis has been done already.
=== modified file 'src/emacs.c'
--- src/emacs.c 2013-10-20 16:47:42 +0000
+++ src/emacs.c 2013-10-25 14:21:47 +0000
@@ -2044,11 +2044,15 @@ You must run Emacs in batch mode in orde
CHECK_STRING (filename);
filename = Fexpand_file_name (filename, Qnil);
+ filename = ENCODE_FILE (filename);
if (!NILP (symfile))
{
CHECK_STRING (symfile);
if (SCHARS (symfile))
- symfile = Fexpand_file_name (symfile, Qnil);
+ {
+ symfile = Fexpand_file_name (symfile, Qnil);
+ symfile = ENCODE_FILE (symfile);
+ }
}
tem = Vpurify_flag;
next prev parent reply other threads:[~2013-10-25 14:25 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 17:46 bug#15260: cannot build in a directory with non-ascii characters Glenn Morris
2013-10-23 20:48 ` Glenn Morris
2013-10-24 18:25 ` Eli Zaretskii
2013-10-24 18:35 ` Glenn Morris
2013-10-25 14:25 ` Eli Zaretskii [this message]
2013-10-25 17:08 ` Glenn Morris
2013-10-25 18:31 ` Eli Zaretskii
2013-10-25 18:40 ` Glenn Morris
2013-10-25 18:46 ` Eli Zaretskii
2013-10-25 19:27 ` Eli Zaretskii
2013-10-26 7:50 ` Eli Zaretskii
2013-10-26 19:15 ` Glenn Morris
2013-10-26 20:04 ` Eli Zaretskii
2013-10-27 3:56 ` Eli Zaretskii
2013-10-27 16:19 ` Eli Zaretskii
2013-10-27 19:02 ` Eli Zaretskii
2013-10-27 19:43 ` Eli Zaretskii
2013-10-27 4:28 ` Stefan Monnier
2013-10-27 16:11 ` Eli Zaretskii
2013-10-28 0:30 ` Stefan Monnier
2013-10-28 3:39 ` Eli Zaretskii
2013-10-28 4:05 ` Stefan Monnier
2013-10-28 16:47 ` Eli Zaretskii
2013-10-28 18:33 ` Eli Zaretskii
2013-10-28 22:00 ` Glenn Morris
2013-10-29 3:42 ` Eli Zaretskii
2013-10-29 1:35 ` Stefan Monnier
2013-10-29 3:47 ` Eli Zaretskii
2013-10-29 13:56 ` Stefan Monnier
2013-10-30 18:19 ` Eli Zaretskii
2013-10-31 1:01 ` Stefan Monnier
2013-10-31 3:47 ` Eli Zaretskii
2013-10-31 13:40 ` Stefan Monnier
2013-10-31 16:25 ` Eli Zaretskii
2013-10-31 18:04 ` Stefan Monnier
2013-10-31 17:59 ` Eli Zaretskii
2013-10-31 19:24 ` Stefan Monnier
2013-10-31 19:33 ` Eli Zaretskii
2013-11-01 9:27 ` Eli Zaretskii
2013-11-01 12:33 ` Stefan Monnier
2013-11-04 17:37 ` Eli Zaretskii
2013-11-04 17:35 ` Eli Zaretskii
2013-11-04 18:38 ` Stefan Monnier
2013-10-31 17:16 ` Eli Zaretskii
2013-10-31 18:09 ` Stefan Monnier
2013-10-31 18:37 ` Eli Zaretskii
2013-10-31 19:41 ` Eli Zaretskii
2013-11-01 13:58 ` Kenichi Handa
2013-10-31 21:45 ` Glenn Morris
2013-11-01 7:45 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83hac5h1ha.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=15260@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).