From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#17947: 24.3; ruby-mode sets require-final-newline unconditionally Date: Sat, 05 Jul 2014 21:38:28 +0300 Message-ID: <83ha2vejmj.fsf@gnu.org> References: <87wqbrllwr.fsf@betacantrips.com> <83ionbekv1.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1404585568 4104 80.91.229.3 (5 Jul 2014 18:39:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Jul 2014 18:39:28 +0000 (UTC) Cc: 17947@debbugs.gnu.org To: Ethan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 05 20:39:20 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X3Urn-0003kn-RB for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jul 2014 20:39:19 +0200 Original-Received: from localhost ([::1]:43681 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3Urn-0001Fq-Ea for geb-bug-gnu-emacs@m.gmane.org; Sat, 05 Jul 2014 14:39:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38532) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3Urd-0001E8-4L for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:39:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X3UrX-0001E1-7y for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:39:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X3UrX-0001Dw-4g for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:39:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1X3UrW-0005lq-Oj for bug-gnu-emacs@gnu.org; Sat, 05 Jul 2014 14:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Jul 2014 18:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17947 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17947-submit@debbugs.gnu.org id=B17947.140458553022146 (code B ref 17947); Sat, 05 Jul 2014 18:39:02 +0000 Original-Received: (at 17947) by debbugs.gnu.org; 5 Jul 2014 18:38:50 +0000 Original-Received: from localhost ([127.0.0.1]:44331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UrJ-0005l8-6g for submit@debbugs.gnu.org; Sat, 05 Jul 2014 14:38:49 -0400 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:54828) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1X3UrF-0005kk-Vj for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 14:38:47 -0400 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0N89005004CAAM00@mtaout25.012.net.il> for 17947@debbugs.gnu.org; Sat, 05 Jul 2014 21:34:30 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N89000M04XIFL70@mtaout25.012.net.il>; Sat, 05 Jul 2014 21:34:30 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91217 Archived-At: > From: Ethan > Date: Sat, 5 Jul 2014 14:19:06 -0400 > Cc: 17947@debbugs.gnu.org > > The idea behind the package is that bad whitespace is highlighted, not > automatically cleaned up. So if the file doesn't have a final newline when > it is first loaded, no final newline will be added without explicit user > action -- instead a red "eof" marker is placed where the final newline > ought to be. > > require-final-newline obviously interferes with this. ethan-wspace could > therefore set it to nil when it is operating, unconditionally. However, I > added functionality to complain if require-final-newline was set -- not > because *users* set it, but because *modes* do, and I wanted to get notice > when that happened. So if you really think ruby-mode should unconditionally > set require-final-newline, it's easy to remove the warning, make it > optional, override require-final-newline on a buffer-local basis, etc. It seems to me that if the buffer being checked has require-final-newline set to a non-nil value, ethan-wspace should simply refrain from checking the final newline, because obviously the user and/or the mode took control of that issue. Wouldn't this be better than bitching at users for setting this option? And I don't think introducing yet another option would solve it. If the user or mode set require-final-newline, IMO that is a clear declaration that the final newline issue is that user's or mode's responsibility; no further options are needed to make that clear. Don't you agree?