unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: larsi@gnus.org, 19421@debbugs.gnu.org
Subject: bug#19421: 25.0.50; doc string of `browse-url' must describe parameter ARGS
Date: Sun, 27 Dec 2015 18:06:08 +0200	[thread overview]
Message-ID: <83h9j3ho5r.fsf@gnu.org> (raw)
In-Reply-To: <10972dc0-33fa-4ff0-974e-96156500da7f@default> (message from Drew Adams on Sat, 26 Dec 2015 14:19:05 -0800 (PST))

> Date: Sat, 26 Dec 2015 14:19:05 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
> Cc: larsi@gnus.org, 19421@debbugs.gnu.org
> 
> >   When called interactively, if variable `browse-url-new-window-flag' is
> >   non-nil, load the document in a new window, if possible, otherwise use
> >   a random existing one.  A non-nil interactive prefix argument reverses
> >   the effect of `browse-url-new-window-flag'.
> > 
> > So this part was already okay (in other functions as well).
> 
> Sorry; I do not understand.  The doc string speaks about behavior
> for when it is called interactively and when it is called
> non-interactively.
> 
> I fail to see how it is called interactively, since it is not a
> command - it has no `interactive' spec.

It describes what will happen with the functions it calls, depending
on the platform.  Those functions do have an interactive spec.

> And it refers to an "optional second argument NEW-WINDOW", but
> the lambda list is (URL &rest ARGS), and the doc string in no
> way introduces NEW WINDOW in terms of those parameters.

Please look at the current sources, you are talking about stuff I
changed already.





  reply	other threads:[~2015-12-27 16:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-20 23:06 bug#19421: 25.0.50; doc string of `browse-url' must describe parameter ARGS Drew Adams
2014-12-20 23:49 ` Drew Adams
2015-12-25 19:02 ` Lars Ingebrigtsen
2015-12-25 23:07   ` Drew Adams
2015-12-26  9:11     ` Eli Zaretskii
     [not found]   ` <<8db0a3c8-08b4-40c3-93a8-23ec9fcd8174@default>
     [not found]     ` <<83bn9dk208.fsf@gnu.org>
2015-12-26 16:40       ` Drew Adams
2015-12-26 18:53         ` Eli Zaretskii
     [not found]   ` <<<8db0a3c8-08b4-40c3-93a8-23ec9fcd8174@default>
     [not found]     ` <<<83bn9dk208.fsf@gnu.org>
     [not found]       ` <<41cee0e8-d5b7-4b6d-8f5b-314c01142f3a@default>
     [not found]         ` <<8337uphwi4.fsf@gnu.org>
2015-12-26 22:19           ` Drew Adams
2015-12-27 16:06             ` Eli Zaretskii [this message]
     [not found]   ` <<<<8db0a3c8-08b4-40c3-93a8-23ec9fcd8174@default>
     [not found]     ` <<<<83bn9dk208.fsf@gnu.org>
     [not found]       ` <<<41cee0e8-d5b7-4b6d-8f5b-314c01142f3a@default>
     [not found]         ` <<<8337uphwi4.fsf@gnu.org>
     [not found]           ` <<10972dc0-33fa-4ff0-974e-96156500da7f@default>
     [not found]             ` <<83h9j3ho5r.fsf@gnu.org>
2015-12-27 16:55               ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h9j3ho5r.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=19421@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).