unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Marcin Borkowski <mbork@mbork.pl>
Cc: 20663@debbugs.gnu.org, ambrevar@gmail.com
Subject: bug#20663: page.el (forward-page): Avoid skipping pages
Date: Sat, 09 Apr 2016 15:00:06 +0300	[thread overview]
Message-ID: <83h9fbhu0p.fsf@gnu.org> (raw)
In-Reply-To: <87h9fbum2w.fsf@mbork.pl> (message from Marcin Borkowski on Sat,  09 Apr 2016 12:13:11 +0200)

> From: Marcin Borkowski <mbork@mbork.pl>
> Date: Sat, 09 Apr 2016 12:13:11 +0200
> Cc: 20663@debbugs.gnu.org
> 
> On 2015-05-26, at 19:14, Pierre Neidhardt <ambrevar@gmail.com> wrote:
> 
> > When `page-delimiter` starts at the beginning of the line and the position is
> > also at the beginning of the line, calling `forward-page` will skip one page.
> >
> > Running `emacs -Q example.txt`:
> >
> > 	M-<
> > 	C-x n p
> > 	M->
> > 	M-1 C-x n p
> >
> > This should bring us from page 1 to page 2, but page 3 gets displayed instead.
> >
> > The attached patch fixes it by changing the code to actually match its
> > surrounding comments.
> 
> Hi Emacs devs,
> 
> could someone take a look at the proposed patch?  It is not installed as
> of GNU Emacs 25.1.50.8 (commit 1e8cd05), and I don't feel competent
> enough to be sure it does not have any adverse side effects.

Maybe I'm missing something, but I don't see the connection between
the description of the bug, the recipe, and the patch.

The description talks about calling forward-page, but the recipe
doesn't call it.  The patch compares page-delimiter with an empty
string, but the default value of page-delimiter is not empty.

So I'm mightily confused by this.  Hopefully, someone will show me
what I'm missing.





  reply	other threads:[~2016-04-09 12:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-26 17:14 bug#20663: page.el (forward-page): Avoid skipping pages Pierre Neidhardt
2016-04-09 10:13 ` Marcin Borkowski
2016-04-09 12:00   ` Eli Zaretskii [this message]
2016-04-09 18:16     ` Marcin Borkowski
2016-04-09 19:34       ` Eli Zaretskii
2016-04-10  1:29         ` Pierre Neidhardt
2016-04-11 10:20           ` Marcin Borkowski
2016-04-11 15:35             ` Eli Zaretskii
2016-04-13 17:53               ` Marcin Borkowski
2016-04-13 20:14                 ` John Mastro
2016-04-13 20:54                   ` Marcin Borkowski
2016-04-16 11:03                 ` Marcin Borkowski
2016-04-16 11:26                 ` Eli Zaretskii
2016-04-20  7:32                   ` Marcin Borkowski
2016-04-27  7:57                     ` Pierre Neidhardt
2016-05-02 20:42                       ` Marcin Borkowski
2016-06-04  9:55                         ` Pierre Neidhardt
2016-06-04 20:36                           ` Marcin Borkowski
2020-09-15 13:53                             ` Lars Ingebrigtsen
2022-04-22 12:05 ` Lars Ingebrigtsen
     [not found]   ` <87pmjje5mt.fsf@kraus.my>
2022-06-09 10:21     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h9fbhu0p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=20663@debbugs.gnu.org \
    --cc=ambrevar@gmail.com \
    --cc=mbork@mbork.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).