From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22891: Date: Tue, 26 Apr 2016 09:44:15 +0300 Message-ID: <83h9eo27k0.fsf@gnu.org> References: <571C868D.2010006@gmx.at> <571F0BEF.7010000@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1461653123 32742 80.91.229.3 (26 Apr 2016 06:45:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2016 06:45:23 +0000 (UTC) Cc: 22891@debbugs.gnu.org, vetoshev@gmail.com, andlind@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 26 08:45:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auwkB-0008UJ-MZ for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Apr 2016 08:45:11 +0200 Original-Received: from localhost ([::1]:36541 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auwkA-0001YY-HQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Apr 2016 02:45:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auwk5-0001Td-U2 for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 02:45:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auwk2-00069Q-Ne for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 02:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auwk2-00069M-Kf for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 02:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1auwk2-00013I-Eu for bug-gnu-emacs@gnu.org; Tue, 26 Apr 2016 02:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Apr 2016 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22891 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22891-submit@debbugs.gnu.org id=B22891.14616530874008 (code B ref 22891); Tue, 26 Apr 2016 06:45:02 +0000 Original-Received: (at 22891) by debbugs.gnu.org; 26 Apr 2016 06:44:47 +0000 Original-Received: from localhost ([127.0.0.1]:47406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auwjn-00012a-0J for submit@debbugs.gnu.org; Tue, 26 Apr 2016 02:44:47 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auwjk-00012N-Q0 for 22891@debbugs.gnu.org; Tue, 26 Apr 2016 02:44:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auwje-00063E-TM for 22891@debbugs.gnu.org; Tue, 26 Apr 2016 02:44:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auwjb-0005xx-4d; Tue, 26 Apr 2016 02:44:35 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2010 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1auwjZ-0005xN-RD; Tue, 26 Apr 2016 02:44:34 -0400 In-reply-to: <571F0BEF.7010000@gmx.at> (message from martin rudalics on Tue, 26 Apr 2016 08:34:23 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116860 Archived-At: > Date: Tue, 26 Apr 2016 08:34:23 +0200 > From: martin rudalics > Cc: 22891@debbugs.gnu.org, Constantine Vetoshev > > > Here comes a new patch with both changes. Unless anybody complains, I will > > push it to "master". > > The fix for bug#22891 should go into emacs-25. Otherwise, we release code > that worked for emacs 24.5. I agree. > > Just a little concern: I just took a look at the Emacs lisp directory. I > > estimate is that a majority (but no all) of calls to `window-width', > > `window-text-width', and `window-body-width' really should be to > > `window-max-chars-per-line'. > > These should be probably fixed on master. Yes; and I'd prefer to see this discussed first, as I'm not so sure the conclusion is correct. This is a tricky issue; in particular, the units in which window-max-chars-per-line measures are different from those of the other functions, so the question is how the result is being used, not just whether the character cell reserved for continuation and truncation glyphs counts.