unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 22891@debbugs.gnu.org, vetoshev@gmail.com, andlind@gmail.com
Subject: bug#22891:
Date: Tue, 26 Apr 2016 09:44:15 +0300	[thread overview]
Message-ID: <83h9eo27k0.fsf@gnu.org> (raw)
In-Reply-To: <571F0BEF.7010000@gmx.at> (message from martin rudalics on Tue, 26 Apr 2016 08:34:23 +0200)

> Date: Tue, 26 Apr 2016 08:34:23 +0200
> From: martin rudalics <rudalics@gmx.at>
> Cc: 22891@debbugs.gnu.org, Constantine Vetoshev <vetoshev@gmail.com>
> 
>  > Here comes a new patch with both changes. Unless anybody complains, I will
>  > push it to "master".
> 
> The fix for bug#22891 should go into emacs-25.  Otherwise, we release code
> that worked for emacs 24.5.

I agree.

>  > Just a little concern: I just took a look at the Emacs lisp directory. I
>  > estimate is that a majority (but no all) of calls to `window-width',
>  > `window-text-width', and `window-body-width' really should be to
>  > `window-max-chars-per-line'.
> 
> These should be probably fixed on master.

Yes; and I'd prefer to see this discussed first, as I'm not so sure
the conclusion is correct.  This is a tricky issue; in particular, the
units in which window-max-chars-per-line measures are different from
those of the other functions, so the question is how the result is
being used, not just whether the character cell reserved for
continuation and truncation glyphs counts.





  reply	other threads:[~2016-04-26  6:44 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-03  6:38 bug#22891: 25.0.92; set-fringe-mode with left fringe 0 breaks window width calculations on Mac OS (again) Constantine Vetoshev
2016-04-11  6:58 ` martin rudalics
2016-04-15  1:24   ` Constantine Vetoshev
2016-04-20 13:48     ` martin rudalics
2016-04-14  5:33 ` Anders Lindgren
2016-04-14 15:17   ` Eli Zaretskii
2016-04-14 18:19     ` Anders Lindgren
2016-04-14 19:24       ` Eli Zaretskii
2016-04-15  7:11         ` Anders Lindgren
2016-04-15  7:42           ` Eli Zaretskii
2016-04-15  8:05             ` Anders Lindgren
2016-04-15  8:25               ` Eli Zaretskii
2016-04-23 18:42 ` bug#22891: Anders Lindgren
2016-04-23 19:03   ` bug#22891: Daniel Colascione
2016-04-24  8:40   ` bug#22891: martin rudalics
2016-04-24 13:04     ` bug#22891: Anders Lindgren
2016-04-24 19:07     ` bug#22891: Anders Lindgren
2016-04-26  6:34       ` bug#22891: martin rudalics
2016-04-26  6:44         ` Eli Zaretskii [this message]
2016-04-26 19:10         ` bug#22891: Anders Lindgren
2016-04-26 19:17           ` bug#22891: Eli Zaretskii
2016-04-26 21:07             ` bug#22891: Anders Lindgren
2016-04-27  6:21               ` bug#22891: Eli Zaretskii
2016-04-27 21:30                 ` bug#22891: Anders Lindgren
2016-04-28  6:33                   ` bug#22891: martin rudalics
2016-04-26 19:03       ` bug#22891: Constantine Vetoshev
2016-04-27 21:38 ` bug#22891: Fixed: 25.0.92; set-fringe-mode with left fringe 0 breaks window width calculations on Mac OS (again) Anders Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h9eo27k0.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=22891@debbugs.gnu.org \
    --cc=andlind@gmail.com \
    --cc=rudalics@gmx.at \
    --cc=vetoshev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).