From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: bo.johansson@lsn.se, 10980@debbugs.gnu.org
Subject: bug#10980: GNU bugs information: logs for bug#10980
Date: Sat, 09 Jul 2016 13:57:33 +0300 [thread overview]
Message-ID: <83h9bzgjtu.fsf@gnu.org> (raw)
In-Reply-To: <CAM-tV--w2VVUYe4Dod+hcrNykU1i8ZQSGL0xOq-W=uMZV4tzKw@mail.gmail.com> (message from Noam Postavsky on Wed, 29 Jun 2016 19:02:25 -0400)
> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Wed, 29 Jun 2016 19:02:25 -0400
> Cc: 10980@debbugs.gnu.org, bo.johansson@lsn.se
>
> Ah, I think I missed the idea that changing Vprocess_environment would
> still affect Emacs' environment (technically, what Emacs thinks its
> environment is, which has the same effect). Patch attached.
Thanks, please push to master, after fixing the following minor
issues:
> * src/emacs.c (main): For WINDOWSNT platform, move init_environment
> calls after the set_initial_environment call. This prevents Emacs'
> modifications to the environment from contaminating Vprocess_environment
> and Vinitial_environment (Bug #10980).
Code changes in fragments guarded by preprocessor conditionals should
be formatted like this:
* src/emacs.c (main) [WINDOWSNT]: Move init_environment calls after ...
> * src/callproc.c (getenv_internal): Consult Emacs' internal environment
> in as a fallback to Vprocess_environment on WINDOWSNT platforms.
Same here.
> + *valuelen = strlen(tmpval);
^^^^^^^
Please leave a single blank between a function's name and the
following opening parenthesis.
> + /* Initialize environment from registry settings. Make sure to do
> + this only after calling set_initial_environment so that
> + Vinitial_environment and Vprocess_environment will contain only
> + variables from the parent process without modifications from
> + Emacs. */
Please leave 2 blanks between the last period of the comment text and
the comment terminator "*/".
Bonus points for adding a test for this issue.
next prev parent reply other threads:[~2016-07-09 10:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAM-tV-8GBPbR3WO9Y_k6mrWop2ZcJCL16R9R2=zmFU5brRp5+w@mail.gmail.com>
[not found] ` <handler.s.R.14653322689344.info.0@debbugs.gnu.org>
2016-06-08 3:54 ` bug#10980: GNU bugs information: logs for bug#10980 Noam Postavsky
2016-06-08 16:40 ` Eli Zaretskii
2016-06-21 0:23 ` Noam Postavsky
2016-06-21 13:27 ` Eli Zaretskii
2016-06-21 21:03 ` Noam Postavsky
2016-06-22 2:39 ` Eli Zaretskii
2016-06-22 2:54 ` Noam Postavsky
2016-06-22 14:57 ` Eli Zaretskii
2016-06-29 13:12 ` Noam Postavsky
2016-06-29 15:15 ` Eli Zaretskii
2016-06-29 15:26 ` Noam Postavsky
2016-06-29 15:34 ` Eli Zaretskii
2016-06-29 23:02 ` Noam Postavsky
2016-07-09 10:57 ` Eli Zaretskii [this message]
2016-07-18 21:52 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h9bzgjtu.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=10980@debbugs.gnu.org \
--cc=bo.johansson@lsn.se \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).