From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23917: Please consider making Bug #23917 a blocker for 25.1 (was Re: org-capture: Capture template =?UTF-8?Q?=E2=80=98g=E2=80=99:?= Match data clobbered by buffer modification hooks) Date: Thu, 21 Jul 2016 05:43:53 +0300 Message-ID: <83h9bjzp5i.fsf@gnu.org> References: <87vb066ejv.fsf@linaro.org> <87bn1yyaui.fsf@linaro.org> <87mvlhmv0x.fsf_-_@moondust.awandering> <837fcl5zs9.fsf@gnu.org> <87a8hgkwcb.fsf@linaro.org> <8360s42mcb.fsf@gnu.org> <87eg6rgmlg.fsf@gmail.com> <83lh0y24y6.fsf@gnu.org> <83eg6q1hbo.fsf@gnu.org> <83a8hd1vzi.fsf@gnu.org> <834m7l1u8u.fsf@gnu.org> <83shv4z7e8.fsf@gnu.org> <83inw0yw9q.fsf@gnu.org> <87bn1rdd1f.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1469069129 13074 80.91.229.3 (21 Jul 2016 02:45:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jul 2016 02:45:29 +0000 (UTC) Cc: nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, 23917@debbugs.gnu.org, monnier@iro.umontreal.ca, alex.bennee@linaro.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 21 04:45:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQ3zB-0008SS-70 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Jul 2016 04:45:17 +0200 Original-Received: from localhost ([::1]:37948 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ3z6-00087E-W5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Jul 2016 22:45:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ3z0-00085Q-R6 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 22:45:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQ3yw-00070Q-C5 for bug-gnu-emacs@gnu.org; Wed, 20 Jul 2016 22:45:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ3yw-00070F-92; Wed, 20 Jul 2016 22:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bQ3yw-0006oM-4x; Wed, 20 Jul 2016 22:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Thu, 21 Jul 2016 02:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23917 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 23917-submit@debbugs.gnu.org id=B23917.146906904826109 (code B ref 23917); Thu, 21 Jul 2016 02:45:02 +0000 Original-Received: (at 23917) by debbugs.gnu.org; 21 Jul 2016 02:44:08 +0000 Original-Received: from localhost ([127.0.0.1]:59147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ3y3-0006n3-R7 for submit@debbugs.gnu.org; Wed, 20 Jul 2016 22:44:08 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47134) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bQ3y2-0006mS-JW for 23917@debbugs.gnu.org; Wed, 20 Jul 2016 22:44:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQ3xw-0006N4-FI for 23917@debbugs.gnu.org; Wed, 20 Jul 2016 22:44:01 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ3xn-0006F1-6y; Wed, 20 Jul 2016 22:43:51 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4663 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bQ3xl-0000Pr-0w; Wed, 20 Jul 2016 22:43:49 -0400 In-reply-to: <87bn1rdd1f.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:121355 Archived-At: > From: npostavs@users.sourceforge.net > Cc: Eli Zaretskii , 23917@debbugs.gnu.org, nljlistbox2@gmail.com, jwiegley@gmail.com, rpluim@gmail.com, alex.bennee@linaro.org > Date: Wed, 20 Jul 2016 20:56:28 -0400 > > >> Maybe there's a misunderstanding. What Noam suggested was just to > >> move the code which adjusts search_regs.start[i] and .end[i] to before > >> the call to replace_range. > > > > Oh, right, that's also an option. It might suffer from another problem, > > which is that the match-data will be broken while the > > before-change-functions are run, so if there's a save-match-data there > > we're back to square one. > > Solution: adjust in between the before and after change functions. > Patch below. I think there shouldn't be performance problems, although > it does add yet another flag to replace_range (by the way, I noticed > that the MARKERS flags is never 0, so it's redundant). I tested with > the attached bug-23917-match-data-buffer-modhook.el. Thanks. Please also make sure bug#23869 is still fixed after this.